fixing minute offset issue in certain time zones#1238
Merged
Conversation
The date solution is still rather hacky, but functions
Tests using UTC values are far more reliable, as we otherwise need to take the runtime conversion of utc time to local time into consideration. The UTC value is what is actually stored in the JS date object.
StephenCathcart
approved these changes
Dec 16, 2024
Contributor
StephenCathcart
left a comment
StephenCathcart
left a comment
There was a problem hiding this comment.
Looks good well documented 👍
MaxAake
added a commit
that referenced
this pull request
Jan 15, 2025
Timezones with minute offsets not divisible by 60 were causing issues for converting from the driver implementation of Date and Datetime to JS Date. A better implementation has been created and some documentation has been updated to reflect limitations that already existed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timezones with minute offsets not divisible by 60 causes issues for converting from the driver implementation of Date and Datetime to JS Date and Datetime