Feature: uses in composite by ChristopherHX · Pull Request #793 · nektos/act

ChristopherHX · 2021-08-30T11:18:32Z

Remove the old hack for composite run steps, use the real runcontext directly.
~~You can also enable if's in composite, I plan to enable it in https://github.com/ChristopherHX/github-act-runner by default.~~
If's are now enabled see https://github.com/actions/runner/releases/tag/v2.284.0

Resolves #783
Resolves #926

This change seems to be functional complete.
Multi nested composite needs more Tests, maybe the size will get xl after more tests are added.

ChristopherHX · 2021-08-30T12:21:02Z

I'm confused,

the runner doesn't log the exit code of the tests
Check failure on linux/macOS, doesn't contains FAIL in the log either
No idea what to try next, is this fail due to the actions/runner???

ChristopherHX · 2021-08-30T14:24:19Z

Wow removing -v from gotest let it succeed (https://github.com/ChristopherHX/act/runs/3462707672?check_suite_focus=true)
Here the same workflow run with -v https://github.com/ChristopherHX/act/runs/3462703235?check_suite_focus=true and it fails.

Oh maybe remove setup-node from tests will solve this....

codecov · 2021-08-30T14:30:52Z

Codecov Report

Merging #793 (99b21b3) into master (0f04942) will increase coverage by 7.78%.
The diff coverage is 64.33%.

@@            Coverage Diff             @@
##           master     #793      +/-   ##
==========================================
+ Coverage   49.27%   57.05%   +7.78%     
==========================================
  Files          23       28       +5     
  Lines        2401     4222    +1821     
==========================================
+ Hits         1183     2409    +1226     
- Misses       1090     1605     +515     
- Partials      128      208      +80

Impacted Files	Coverage Δ
pkg/common/executor.go	`46.90% <0.00%> (+2.03%)`	⬆️
pkg/common/job_error.go	`0.00% <0.00%> (ø)`
pkg/common/outbound_ip.go	`0.00% <0.00%> (ø)`
pkg/common/testflag.go	`0.00% <0.00%> (ø)`
pkg/container/docker_volume.go	`0.00% <0.00%> (ø)`
pkg/model/action.go	`0.00% <0.00%> (ø)`
pkg/container/docker_run.go	`5.54% <14.15%> (+3.61%)`	⬆️
pkg/common/git.go	`49.82% <31.81%> (-9.97%)`	⬇️
pkg/runner/logger.go	`65.43% <37.50%> (+1.28%)`	⬆️
pkg/container/docker_auth.go	`45.00% <45.00%> (ø)`
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ef30c3...99b21b3. Read the comment docs.

mergify · 2021-12-22T06:37:32Z

@ChristopherHX this pull request is now in conflict 😩

mergify · 2021-12-22T08:20:07Z

@ChristopherHX this pull request has failed checks 🛠

ChristopherHX · 2021-12-22T08:23:14Z

Please help me, what is wrong with superlinter? It just crashs because a file is missing?
https://github.com/nektos/act/runs/4604475831?check_suite_focus=true

I resolved the merge conflict of today.

catthehacker · 2021-12-22T08:30:59Z

@ChristopherHX it's broken, don't worry about your update

catthehacker · 2021-12-22T08:31:27Z

https://github.com/github/super-linter/issues/2253

mergify · 2021-12-22T17:30:23Z

@ChristopherHX this pull request is now in conflict 😩

catthehacker · 2021-12-22T19:20:15Z

🎉

davetapley · 2021-12-28T18:40:54Z

@catthehacker any chance of getting a new release with this in? 🙏🏻

* Feature: uses in composite * Negate logic * Reduce complexity * Update step_context.go * Update step_context.go * Update step_context.go * Fix syntax error in test * Bump * Disable usage of actions/setup-node@v2 * Bump * Fix step id collision * Fix output command workaround * Make secrets context inaccessible in composite * Fix order after adding a workaround (needs tests) Fixes nektos/act#793 (comment) * Evaluate env before passing one step deeper If env would contain any inputs, steps ctx or secrets there was undefined behaviour * [no ci] prepare secret test * Initial test pass inputs as env * Fix syntax error * extend test also for direct invoke * Fix passing provided env as composite output * Fix syntax error * toUpper 'no such secret', act has a bug * fix indent * Fix env outputs in composite * Test env outputs of composite * Fix inputs not defined in docker actions * Fix interpolate args input of docker actions * Fix lint * AllowCompositeIf now defaults to true see https://github.com/actions/runner/releases/tag/v2.284.0 * Fix lint * Fix env of docker action.yml * Test calling a local docker action from composite With input context hirachy * local-action-dockerfile Test pass on action/runner It seems action/runner ignores overrides of args, if the target docker action has the args property set. * Fix exec permissions of docker-local-noargs * Revert getStepsContext change * fix: handle composite action on error and continue This change is a follow up of nektos/act#840 and integrates with nektos/act#793 There are two things included here: - The default value for a step.if in an action need to be 'success()' - We need to hand the error from a composite action back to the calling executor Co-authored-by: Björn Brauer <[email protected]> * Patch inputs can be bool, float64 and string for workflow_call Also inputs is now always defined, but may be null * Simplify cherry-picked commit * Minor style adjustments * Remove chmod +x from tests now fails on windows like before * Fix GITHUB_ACTION_PATH some action env vars Fixes GITHUB_ACTION_REPOSITORY, GITHUB_ACTION_REF. * Add comment to CompositeRestrictions Co-authored-by: Markus Wolf <[email protected]> Co-authored-by: Björn Brauer <[email protected]> Co-authored-by: Ryan <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Feature: uses in composite

6d6934b

pull-request-size bot added the size/L label Aug 30, 2021