Skip to content

Update images, fix extrapath#723

Merged
mergify[bot] merged 9 commits intonektos:masterfrom
catthehacker:cat/fix/change-image
Jun 10, 2021
Merged

Update images, fix extrapath#723
mergify[bot] merged 9 commits intonektos:masterfrom
catthehacker:cat/fix/change-image

Conversation

@catthehacker
Copy link
Member

  • 18549c9 - fix: typo
  • bc3fca4 - fix: remove debug for git references:
    it generates a massive amount of logs
  • d1f1875 - feat: read values from env:
    allows to test act on GHA when it's not a main repo
  • 28bd850 - fix: merge extrapath with PATH
  • 8d0b059 - fix(tests): add additional shells for testing
  • 0cf3600 - fix(image): update images:
    pin node to major version only, current node version: 12.22.1
    replace most images with node:12-buster-slim to prevent
    errors on macOS runner due to DockerHub pull limit
    replace ocaml image

hackercat added 6 commits June 5, 2021 15:56
it generates a massive amount of logs
allows to test act on GHA when it's not a main repo
pin node to major version only, current node version: 12.22.1
replace most images with `node:12-buster-slim` to prevent
errors on macOS runner due to DockerHub pull limit
replace ocaml image
@catthehacker catthehacker requested a review from a team as a code owner June 5, 2021 16:00
@codecov
Copy link

codecov bot commented Jun 5, 2021

Codecov Report

Merging #723 (4fb215a) into master (0f04942) will increase coverage by 1.01%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #723      +/-   ##
==========================================
+ Coverage   49.27%   50.29%   +1.01%     
==========================================
  Files          23       23              
  Lines        2401     2579     +178     
==========================================
+ Hits         1183     1297     +114     
- Misses       1090     1142      +52     
- Partials      128      140      +12     
Impacted Files Coverage Δ
pkg/container/docker_run.go 1.84% <0.00%> (-0.09%) ⬇️
pkg/model/workflow.go 25.29% <2.43%> (-0.43%) ⬇️
pkg/common/git.go 52.85% <30.15%> (-6.94%) ⬇️
pkg/runner/runner.go 68.96% <33.33%> (-7.51%) ⬇️
pkg/model/planner.go 34.56% <41.37%> (+1.48%) ⬆️
pkg/container/docker_pull.go 36.17% <64.70%> (+17.98%) ⬆️
pkg/runner/step_context.go 75.06% <76.71%> (+6.11%) ⬆️
pkg/runner/run_context.go 79.84% <95.52%> (+3.44%) ⬆️
pkg/runner/command.go 90.58% <100.00%> (+2.35%) ⬆️
pkg/runner/logger.go 64.81% <100.00%> (+0.66%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9295c9...4fb215a. Read the comment docs.

@mergify
Copy link
Contributor

mergify bot commented Jun 5, 2021

@catthehacker this pull request has failed checks 🛠

@mergify mergify bot added needs-work Extra attention is needed and removed needs-work Extra attention is needed labels Jun 5, 2021
@mergify
Copy link
Contributor

mergify bot commented Jun 9, 2021

@catthehacker this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Jun 9, 2021
@mergify mergify bot removed the needs-work Extra attention is needed label Jun 10, 2021
catthehacker pushed a commit to JustinGrote/_PR-act that referenced this pull request Jun 10, 2021
mergify bot added a commit that referenced this pull request Jun 10, 2021
* Test fixups for Windows/Forks

* revert change for repo/actor/owner

this is fixed via #723

Co-authored-by: Ryan (hackercat) <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@catthehacker catthehacker requested a review from a team June 10, 2021 18:32
@mergify mergify bot merged commit a9fe038 into nektos:master Jun 10, 2021
@catthehacker catthehacker deleted the cat/fix/change-image branch August 1, 2021 15:46
project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-runner-as-gitea-act-runner-fork that referenced this pull request Jul 28, 2025
* Test fixups for Windows/Forks

* revert change for repo/actor/owner

this is fixed via nektos/act#723

Co-authored-by: Ryan (hackercat) <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
underth-moon99 added a commit to underth-moon99/act that referenced this pull request Jul 29, 2025
* Test fixups for Windows/Forks

* revert change for repo/actor/owner

this is fixed via nektos/act#723

Co-authored-by: Ryan (hackercat) <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants