Refactor git to add more errors, tests and specific GitHub Actions error#679
Merged
mergify[bot] merged 1 commit intonektos:masterfrom May 8, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #679 +/- ##
==========================================
+ Coverage 49.27% 50.01% +0.74%
==========================================
Files 23 23
Lines 2401 2523 +122
==========================================
+ Hits 1183 1262 +79
- Misses 1090 1124 +34
- Partials 128 137 +9
Continue to review full report at Codecov.
|
Contributor
|
@catthehacker this pull request has failed checks 🛠 |
adding more tests returns same message for short SHA format like GitHub Actions refactor error checking add more errors :)
catthehacker
force-pushed
the
cat/fix/git-short-sha-error
branch
from
665ef1f to
3172d33
Compare
cplee
approved these changes
May 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor: return more errors, add more tests
adding more tests
returns same message for short SHA format like GitHub Actions
refactor error checking
add more errors :)