Remove pwsh -login and add Pwsh test#660
Conversation
Codecov Report
@@ Coverage Diff @@
## master #660 +/- ##
==========================================
+ Coverage 49.27% 49.85% +0.58%
==========================================
Files 23 23
Lines 2401 2401
==========================================
+ Hits 1183 1197 +14
+ Misses 1090 1078 -12
+ Partials 128 126 -2
Continue to review full report at Codecov.
|
|
@JustinGrote this pull request has failed checks 🛠 |
…nded out later Reference: nektos#660 (comment)
|
@JustinGrote this pull request has failed checks 🛠 |
|
@cplee @catthehacker looks like the composite test is flaky on MacOS, maybe a race condition. Empty commit and it worked this time :) |
|
@catthehacker - I'd like to test mergify workflow with this one...can you add an |
|
@JustinGrote this pull request has failed checks 🛠 |
|
@Mergifyio refresh |
|
Command
|
|
Took some persistence, but Mergify is all dialed in |
* Remove pwsh -login and add Pwsh test * Add Shell Command Test for coverage * 🧪 Move PWSH Platform definition to inline test, it can always be expanded out later Reference: nektos/act#660 (comment) * Test MacOS Build for transient failure Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* Remove pwsh -login and add Pwsh test * Add Shell Command Test for coverage * 🧪 Move PWSH Platform definition to inline test, it can always be expanded out later Reference: nektos/act#660 (comment) * Test MacOS Build for transient failure Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 participants
This resolves the issue with pwsh failing due to -login and the command not splitting correctly.
It also adds a test pwsh run using a image that has Powershell integrated, hopefully this doesn't introduce too much into the testing time, but the image can be cached in the CI if necessary to speed things up.
EDIT: Literally took less than half a second to download and extract the container, I guess that's a benefit of using the github container registry :)