Skip to content

Conversation

@pelikhan
Copy link
Contributor

@pelikhan pelikhan commented May 20, 2025

Fixes #2766

This is a new permission to support GitHub Models in Actions.

  • updated the schema... but unclear about new steps.
  • make pr touched a few other files, which I ignored as they were unrelated

@ChristopherHX
Copy link
Contributor

ChristopherHX commented May 21, 2025

@mergify mergify bot added the needs-work Extra attention is needed label May 21, 2025
@ChristopherHX
Copy link
Contributor

Information: Test failure is unrelated, GitHub Hosted Runner change made this test fail outside of docker. Disabling this test was not merged.

@pelikhan
Copy link
Contributor Author

Do you want me to pull the full updated in? I didn't realize this was the source of truth.

@ChristopherHX
Copy link
Contributor

Do you want me to pull the full updated in?

Optional, not a merge requirement for me.

A second PR approval is a merge requirement.

Thanks for the information that the permission field got an update, not polling frequently anymore.

I confirm changing this single json file is enough to work correctly with act and nothing more is needed.

@ChristopherHX
Copy link
Contributor

I didn't realize this was the source of truth

I guess adding a readme.md file explaining where the files are coming from might makes sense

@panekj panekj force-pushed the pelikhan/permissions-models-read branch from 38ca4d7 to 2b0c09e Compare May 22, 2025 21:06
@codecov
Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.66%. Comparing base (5a80a04) to head (12b9a10).
Report is 204 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2767       +/-   ##
===========================================
+ Coverage   61.56%   74.66%   +13.10%     
===========================================
  Files          53       73       +20     
  Lines        9002    11139     +2137     
===========================================
+ Hits         5542     8317     +2775     
+ Misses       3020     2185      -835     
- Partials      440      637      +197     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify mergify bot removed the needs-work Extra attention is needed label May 22, 2025
@mergify mergify bot merged commit bd4bc99 into nektos:master May 22, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

permissions models: read

3 participants