fix: reporting fetch failure as job error and log the error #2715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E.g. if GoGitAction Cache had a fetch failure this error did not trigger report jobResult Failure. Also the error has been not printed until the last message before exit of act. * adds tests for both corner cases
Contributor
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports
|
Contributor
Author
|
Hmm, this does no longer work in the old codebase? Need to look at this |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2715 +/- ##
===========================================
+ Coverage 61.56% 74.59% +13.03%
===========================================
Files 53 72 +19
Lines 9002 11065 +2063
===========================================
+ Hits 5542 8254 +2712
+ Misses 3020 2179 -841
- Partials 440 632 +192 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Phantom failure, this is concerning |
cplee
approved these changes
Mar 29, 2025
mergify
bot
deleted the
christopherhx/fix-reporting-fetch-failure-as-job-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g. if GoGitAction Cache had a fetch failure this error did not trigger report jobResult Failure.
Also the error has been not printed until the last message before exit of act.
We need more tests like this to ensure consistent logging