Skip to content

Fix #2363. Add /pre- and /post-entrypoint handling#2394

Merged
mergify[bot] merged 3 commits intonektos:masterfrom
AndriiChyrva:2363-pre-n-post-entrypoints-docker-actions-not-executed-0
Jul 24, 2024
Merged

Fix #2363. Add /pre- and /post-entrypoint handling#2394
mergify[bot] merged 3 commits intonektos:masterfrom
AndriiChyrva:2363-pre-n-post-entrypoints-docker-actions-not-executed-0

Conversation

@AndriiChyrva
Copy link
Contributor

@AndriiChyrva AndriiChyrva commented Jul 11, 2024

Fix #2363. Add /pre- and /post-entrypoint handling

@AndriiChyrva AndriiChyrva requested a review from a team as a code owner July 11, 2024 14:29
@mergify
Copy link
Contributor

mergify bot commented Jul 11, 2024

@AndriiChyrva this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Jul 11, 2024
@ChristopherHX
Copy link
Contributor

ChristopherHX commented Jul 11, 2024

Thank you, I will look into the failing workflows in ca. 8 days and help you to resolve them

There might be some regressions in this PR or tests testing the wrong thing

@AndriiChyrva
Copy link
Contributor Author

AndriiChyrva commented Jul 12, 2024

Thank you, I will look into the failing workflows in ca. 8 days and help you to resolve them

There might be some regressions in this PR or tests testing the wrong thing

Awesome! Thank you for support.
Probably I forgot to fix test of execAsDocker(...) function because I changed the amount of parameter in this one.

@mergify
Copy link
Contributor

mergify bot commented Jul 18, 2024

@AndriiChyrva this pull request has failed checks 🛠

@ChristopherHX
Copy link
Contributor

ChristopherHX commented Jul 19, 2024

I found one issue where you probably did copy paste from the pre to the post condition where pre has not been replaced by post

@codecov
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 56.60377% with 23 lines in your changes missing coverage. Please review.

Project coverage is 76.47%. Comparing base (5a80a04) to head (c59e536).
Report is 93 commits behind head on master.

Files Patch % Lines
pkg/runner/action.go 56.60% 19 Missing and 4 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #2394       +/-   ##
===========================================
+ Coverage   61.56%   76.47%   +14.91%     
===========================================
  Files          53       61        +8     
  Lines        9002     7919     -1083     
===========================================
+ Hits         5542     6056      +514     
+ Misses       3020     1307     -1713     
- Partials      440      556      +116

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot removed the needs-work Extra attention is needed label Jul 19, 2024
ChristopherHX
ChristopherHX approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me now, all tests are passing.

I might not have tested the new feature itself, more looked at the broken tests and fixed the logic error

@mergify mergify bot merged commit 570ccf3 into nektos:master Jul 24, 2024
@AndriiChyrva AndriiChyrva deleted the 2363-pre-n-post-entrypoints-docker-actions-not-executed-0 branch March 26, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfogre wolfogre wolfogre approved these changes

@ChristopherHX ChristopherHX ChristopherHX approved these changes

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The pre-entrypoint and post-entrypoint of Docker Actions are not Executed

3 participants

@AndriiChyrva @ChristopherHX @wolfogre