Repository navigation
Commit 0eafd4d
chore: move datafusion-ffi integration tests into their own crate (apache#26564)
## Which issue does this PR close?
- Closes apache#26559.
## Rationale for this change
`datafusion-ffi` is built as a `cdylib` only so that its own integration
tests can `dlopen` it.
Every downstream build pays for compiling and linking that unused shared
library, and `sccache` can't cache crates with a `cdylib` crate type.
## What changes are included in this PR?
- New unpublished crate `datafusion-ffi-integration-tests` in
`datafusion/ffi/integration-tests/`, built as a `cdylib`, which
re-exports the `#[no_mangle]` test entry points from
`datafusion_ffi::tests`.
Its `integration-tests` feature enables
`datafusion-ffi/integration-tests`, so regular workspace builds still
don't compile the test module.
- `datafusion/ffi/tests/` moves there unchanged, and `find_library`
looks for the new library name.
- `datafusion-ffi` is now a plain `rlib`.
- The `test ffi` xtask step and the `datafusion-ffi` agent skill include
the new crate.
The new crate needs both `cdylib` and `rlib`: with only `cdylib`, Cargo
doesn't build the library before running the crate's integration tests.
## What is the testing strategy for this PR?
Covered by the existing FFI integration tests, which now load the new
crate's `cdylib`.
## Are there any user-facing changes?
The public API and ABI of `datafusion-ffi` are unchanged. Crates that
build their own `cdylib` on top of `datafusion-ffi` are unaffected.
---
This PR was prepared with the help of a coding agent (Claude).
Co-authored-by: Tim Saucer <[email protected]>1 parent 659b475 commit 0eafd4d
20 files changed
Lines changed: 102 additions & 7 deletions
File tree
- .ai/skills/datafusion-ffi
- datafusion/ffi
- integration-tests
- src
- tests
- cases
- utils
- src/tests
- xtask/src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
197 | 197 | | |
198 | 198 | | |
199 | 199 | | |
200 | | - | |
| 200 | + | |
201 | 201 | | |
202 | | - | |
| 202 | + | |
203 | 203 | | |
204 | 204 | | |
205 | 205 | | |
206 | 206 | | |
207 | | - | |
| 207 | + | |
208 | 208 | | |
209 | 209 | | |
210 | 210 | | |
211 | 211 | | |
212 | 212 | | |
213 | 213 | | |
214 | | - | |
| 214 | + | |
215 | 215 | | |
216 | 216 | | |
217 | 217 | | |
| |||
347 | 347 | | |
348 | 348 | | |
349 | 349 | | |
350 | | - | |
| 350 | + | |
351 | 351 | | |
352 | 352 | | |
353 | 353 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| 35 | + | |
35 | 36 | | |
36 | 37 | | |
37 | 38 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
42 | 41 | | |
43 | 42 | | |
44 | 43 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
0 commit comments