-
Notifications
You must be signed in to change notification settings - Fork 0
[fix] Restores 3d Views to PR #556 -- Java 11 upgrade #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
044f43a to
cb9aed3
Compare
|
Intellij doesn't automatically pull the |
|
Ah, I had to do this: https://stackoverflow.com/a/1051705/3339274 with the |
|
@teyrana We can merge this once you add the following lines to the bottom of the <orderEntry type="library" name="jogl-all" level="project" />
<orderEntry type="library" name="jogl" level="project" />In context: <orderEntry type="module-library">
<library>
<CLASSES>
<root url="jar://$MODULE_DIR$/../lib-test/uispec4j-2.3-jdk16.jar!/" />
</CLASSES>
<JAVADOC />
<SOURCES />
</library>
</orderEntry>
<orderEntry type="library" name="jogl-all" level="project" />
<orderEntry type="library" name="jogl" level="project" />
</component>
</module> |
Dangit, that's exactly what this was supposed to fix :(
I went to the build settings > artifact ,and added extracted versions if all the native libraries Okay, I'll take another look at it. |
|
@neilbalch The changes of interested are:
Specifically, I'm trying to fixed two things:
Both work for me, on my windows machine; so if they're not working for you, it's probably something about the build system config files, I think? |
|
@teyrana Maybe that's the case. Intellij didn't know where to find the jogl library |
|
Sorry, I don't follow. I literally can't reproduce the the issue. Can you elaborate? ( if one can't reproduce a problem, one can't validate the corresponding fix... ) |
|
What I'm trying to say is that I think my problem would be resolved by you submitting an addendum to this patch following my recommendations earlier. I'm pretty sure I'm running a similar system setup to you, Windows 10 with Intellij set to the latest official Java JDK 13 release. (i.e. not OpenJDK) Looking back at our correspondence, I don't think I explained why I believe my recommendation to be an appropriate fix. I think that when you initially added the jogl library to Intellij a few days ago Intellij didn't properly record it into its own xml config files. The xml patch I suggest is what Intellij changed when I re-added the jogl library to the project in the Intellij interface. |
|
You know, it sounds both a lot easier, and less error-prone if you just push the changes you're talking about to the parent branch directly. There are a couple ways to do that, off the top of my head . . .
What would get us moving forward ? p.s. Here's the jarfile that my branch builds Does it at least run for you? |
|
Sorry for the delayed response, I've had a lot on my plate recently. Your build works perfectly fine, I have no doubt that the patch works, it's just the Intellij Idea configuration to build it that's dysfunctional. I think I'll merge and push my changes on top, thanks for the recommendation. |
|
Yea, I think our intellij setups vary somehow. But it sounds like we both have more interesting things to do, for now. |
|
@neilbalch |
Edit: rebased to the front of your branch :)