Skip to content

Rework pairing and host requesting#360

Merged
nefarius merged 39 commits intonefarius:masterfrom
Kanuan:custom-pairing-there-n-back-again
May 17, 2024
Merged

Rework pairing and host requesting#360
nefarius merged 39 commits intonefarius:masterfrom
Kanuan:custom-pairing-there-n-back-again

Conversation

@Kanuan
Copy link
Copy Markdown
Collaborator

@Kanuan Kanuan commented May 10, 2024 •
edited
Loading

  • Pairing now has 3 main modes:
    • Auto: to active host
    • Custom: to user defined Mac address
    • Disabled: never occurs
  • Pairing can be triggered manually by enabling the new PairOnHotReload and hot-reloading configurations
    • Pairing is set to NOT occur if the desired new host is equal to the current set one, but I've included this option to prevent an edge case in which dshidmini could spam the controller on every hot reload with pairing requests if the driver failed to get the current controller's host
    • Resolves Make pairing process occur on hot-reload #315
  • DsHidMini now only sets the device's host request by sending the appropriate request to the controller
    • Before it assumed the controller had set the new host address if the pairing request was sent successfully
    • If the controller fails to respond to the request of its host address then DsHidMini will fallback to all zeroes host address
    • Host is requested after each pairing attempt regardless if the pairing has succeeded or not, so it's possible to trigger the host requesting by enabling the PairOnHotReload config which will auto-trigger hot-reloading
    • Resolves Only update device context's host address by using its respective GetFeature request #357
  • Add "get host address" request status property
  • Removed legacy "DisableAutoPair" config
  • Pairing is only attempted after configurations have been loaded

Kanuan added 30 commits May 6, 2024 20:33
@Kanuan
Add device pairing modes enum
1a482ee
@Kanuan
Add paireing mode friendly names for json reading
ae7276a
@Kanuan
Add variables
dd0048f
@Kanuan
Refactored code
d72d006
@Kanuan
auto-pair to current host only if in auto mode
e83fd02
@Kanuan
skip pairing process if in mode disabled
47741ff
@Kanuan
set device host address to custom defined one if in mode custom
6784f2e
@Kanuan
Implement translation of friendly name to enum
ae936b3
@Kanuan
Renamed enum
128ba6c
@Kanuan
Renamed field
b035c55
@Kanuan
Set default values for pairing configurations
24f6c88
@Kanuan
Implement reading pairing configuration from disk
a57b800
@Kanuan
fix reversing while copying logic
20ea3e9
@Kanuan
Introduce property for host request status
b3aba55
@Kanuan
Implement PairOnHotReload config
bcd6754
@Kanuan
Refactored code
ac446dc
@Kanuan
Add method for requesting device's host address
bace964
@Kanuan
Rename method and its description
866ca5e
@Kanuan
Refactored code
cc9430e
@Kanuan
Attempt pairing only after configs have been loaded
91d32dd
@Kanuan
Request new host after attempting to pair
07e442c
@Kanuan
Attempt pairing and requesting host on hot-reload
9c05b1a
@Kanuan
Tweaked tracing message
0b7573a
@Kanuan
Refactored code
7cc7660
@Kanuan
Do not assume device's host was updated after pairing request
47b644f
@Kanuan
Fix method never returning successful status
22d49bc
@Kanuan
Add tracing
675944c
@Kanuan
Fix method calling
3ee64cd
@Kanuan
Add tracing
153cbd1
@Kanuan
Change trace message to information type
c9149cb
@nefarius nefarius added this to the Version 3 milestone May 10, 2024
@nefarius nefarius self-assigned this May 12, 2024
@nefarius nefarius added enhancement New feature or request USB USB-related (wired) labels May 12, 2024
@nefarius nefarius merged commit a80eadf into nefarius:master May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nefarius nefarius

Labels

enhancement New feature or request USB USB-related (wired)

Projects

None yet

Milestone

Version 3

Development

Successfully merging this pull request may close these issues.

Only update device context's host address by using its respective GetFeature request Make pairing process occur on hot-reload

2 participants

@Kanuan @nefarius