Reworked rumble configuration and processing#354
Merged
nefarius merged 13 commits intonefarius:masterfrom Apr 25, 2024
Merged
Conversation
Collaborator
Kanuan
commented
Apr 24, 2024
Kanuan
commented
- Changed the structure of user defined rumble configurations
- Updated rumble configuration loading from disk to fit changes
- Re-purposed structure that store last received rumble intensities to also store current state of rumble rescaling
- Before the current state was read/write directly to the user configurations
- Added a IsAllowed property for the current state of rumble rescalers so rescaling can be "blocked" even if it's enabled
- Set to false if user-defined rescaling ranges are invalid
- Reworked rumble processing to reflect changes above
- Rescaling constants, if they are enabled and if they are allowed are now fetched from the re-purposed struct commented above
- Changed rumble processing logic so motors can only be disabled while in normal mode
Collaborator
Author
|
I confirm everything is working as expected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.