Fix loading of custom LEDs settings#348
Merged
nefarius merged 17 commits intonefarius:masterfrom Apr 24, 2024
Merged
Conversation
Owner
|
If BasePortionDuration is effectively one 16bit value, make it an USHORT. Beware of byte order though when setting it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the logic used for loading each Player LED settings from the disk configuration file. (related to #260 )
Besides that, I've renamed some variables to reflect the actual functioning of the LED effects as discussed in #314 . The chosen names are:
Because the base portion duration is a 2 byte value represented by BasePortionDuration1 and BasePortionDuration0 I've considered turning it into an array BasePortionDuration[2]. Tell me if it would be better and I'll update the PR