Skip to content

Only update device context's host address by using its respective GetFeature request #357

@Kanuan

Description

@Kanuan

When on USB, there are 2 situations in which DsHidMini updates the device's host address field that is stored in the Device Context:

  1. It sends a GetFeature request and saves the host address informed by the controller when it responds
    • Occurs in the DsUsb_PrepareHardware method
  2. When a pairing request is sent to the controller and is considered successful, then it automatically updates the device's context host address field to the same one sent in the request
    • Occurs in the method currently known as DsUsb_Ds3PairToFirstRadio

I'd like to know your thoughts on removing the automatic updating done in (2), and replacing it with what happens in (1).

My line of thinking is that it would be better to always confirm what host address the controller is informing instead of assuming it was updated by the pairing request.

This would give us more info in situations in which the driver considers the pairing request succeeded but the controller continues informing it is paired to another MAC address

Metadata

Metadata

Assignees

No one assigned

    Labels

    USBUSB-related (wired)enhancementNew feature or request

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions