Set Created to 0001-01-01T00:00:00Z on older API versions

tianon · tianon · commit b4fbe226e8c2 · 2024-02-12T12:39:16.000-08:00
This matches the prior behavior before 2a6ff3c. This also updates the Swagger documentation for the current version to note that the field might be the empty string and what that means. Signed-off-by: Tianon Gravi <admwiggin@gmail.com>
diff --git a/api/server/router/image/image_routes.go b/api/server/router/image/image_routes.go
@@ -299,6 +299,12 @@ func (ir *imageRouter) getImagesByName(ctx context.Context, w http.ResponseWrite
 	version := httputils.VersionFromContext(ctx)
 	if versions.LessThan(version, "1.44") {
 		imageInspect.VirtualSize = imageInspect.Size //nolint:staticcheck // ignore SA1019: field is deprecated, but still set on API < v1.44.
+
+		if imageInspect.Created == "" {
+			// backwards compatibility for Created not existing returning "0001-01-01T00:00:00Z"
+			// https://github.com/moby/moby/issues/47368
+			imageInspect.Created = time.Time{}.Format(time.RFC3339Nano)
+		}
 	}
 	return httputils.WriteJSON(w, http.StatusOK, imageInspect)
 }
diff --git a/api/swagger.yaml b/api/swagger.yaml
@@ -1746,7 +1746,7 @@ definitions:
       Created:
         description: |
           Date and time at which the image was created, formatted in
-          [RFC 3339](https://www.ietf.org/rfc/rfc3339.txt) format with nano-seconds.
+          [RFC 3339](https://www.ietf.org/rfc/rfc3339.txt) format with nano-seconds, or empty if the field was not set in the image config.
         type: "string"
         x-nullable: false
         example: "2022-02-04T21:20:12.497794809Z"
diff --git a/docs/api/v1.44.yaml b/docs/api/v1.44.yaml
@@ -1742,7 +1742,7 @@ definitions:
       Created:
         description: |
           Date and time at which the image was created, formatted in
-          [RFC 3339](https://www.ietf.org/rfc/rfc3339.txt) format with nano-seconds.
+          [RFC 3339](https://www.ietf.org/rfc/rfc3339.txt) format with nano-seconds, or empty if the field was not set in the image config.
         type: "string"
         x-nullable: false
         example: "2022-02-04T21:20:12.497794809Z"

Original file line number	Diff line number	Diff line change
`@@ -299,6 +299,12 @@ func (ir *imageRouter) getImagesByName(ctx context.Context, w http.ResponseWrite`
`299`	`299`	`version := httputils.VersionFromContext(ctx)`
`300`	`300`	`if versions.LessThan(version, "1.44") {`
`301`	`301`	`imageInspect.VirtualSize = imageInspect.Size //nolint:staticcheck // ignore SA1019: field is deprecated, but still set on API < v1.44.`
	`302`	`+`
	`303`	`+ if imageInspect.Created == "" {`
	`304`	`+ // backwards compatibility for Created not existing returning "0001-01-01T00:00:00Z"`
	`305`	`+ // https://github.com/moby/moby/issues/47368`
	`306`	`+ imageInspect.Created = time.Time{}.Format(time.RFC3339Nano)`
	`307`	`+ }`
`302`	`308`	`}`
`303`	`309`	`return httputils.WriteJSON(w, http.StatusOK, imageInspect)`
`304`	`310`	`}`