You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 9f2526f
Browse filesBrowse the repository at this point in the historyBrowse files
Addresses code-review findings on the SkillV2 no-restart skill refresh
(commit 6860c42, issue anomalyco#37426):
- Add a 60-minute cache-clear timer for url-type sources only; there is
no push notification for arbitrary HTTP endpoints, so this is the one
automatic way to observe a changed remote catalog while running.
Directory sources remain purely event-driven via the existing
finalize-triggered watch sync.
- Fix a scope/finalizer leak: each directory watch's Effect.acquireRelease
finalizer was tied to the service's single long-lived scope, and manually
running the stored unsubscribe on removal never deregistered it. Directory
watches now use a per-watch child scope (Scope.fork/Scope.close), which
Effect detaches from the parent on close instead of accumulating.
- Fix symlinked directory sources never invalidating: invalidateDirectory
now compares against the watched directory's resolved real path (native
watcher backends report events using the resolved path), matching the
existing realpath handling for git directories in this same file.
- Fix a native watch-handle leak in watcher.ts's watch() when subscribe()
resolves after the 10s timeout, mirroring the existing subscribe()
cleanup path.
- Fix a cache-resurrection race: an in-flight list() load could resurrect
a cache entry a concurrent reconcile had just invalidated; list() now
only caches its result if no reconcile ran while the load was in flight.
- Note the intentional duplication between this file's
OPENCODE_DISABLE_EXTERNAL_SKILLS/OPENCODE_DISABLE_CLAUDE_CODE_SKILLS and
packages/opencode's RuntimeFlags equivalents (core cannot depend on
opencode, so both must be kept in sync manually).
- Add tests: url-source refresh via the periodic timer (using TestClock),
and an end-to-end symlinked-directory invalidation test against the real
filesystem watcher (previously only a stubbed watcher was exercised).
bun typecheck and bun test (packages/core, 1080 pass) are green.
Co-Authored-By: Claude Sonnet 5 <[email protected]>
0 commit comments