Skip to content

Commit 11ff945

Browse files
authored
test(conformance): ignore slow-TERM delete until the supervisor half of NVIDIA#5025 lands (NVIDIA#5338)
The test fails on Podman because the supervisor container waits out its stop timeout. Also list ignored tests in check-conformance-program.sh so the program list still matches nextest's. Signed-off-by: Evan Lezar <[email protected]>
1 parent 6389745 commit 11ff945

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

‎tasks/scripts/check-conformance-program.sh‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@ trap 'rm -rf "${work}"' EXIT
1616

1717
cargo run --quiet --locked --manifest-path "${manifest}" --bin openshell-conformance -- list \
1818
| awk '{print $1}' | sort > "${work}/program"
19-
cargo nextest list --locked --color never --manifest-path "${manifest}" --message-format oneline \
19+
# --run-ignored all: the program lists ignored tests too, so nextest must as well.
20+
cargo nextest list --locked --color never --run-ignored all --manifest-path "${manifest}" --message-format oneline \
2021
| awk '{print $2}' | sort > "${work}/nextest"
2122

2223
if [[ ! -s "${work}/nextest" ]]; then

‎tests/suites/conformance/src/lifecycle.rs‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,11 @@ const DELETE_DEADLINE: Duration = Duration::from_secs(10);
5252
/// Many workloads do not exit immediately on TERM, for example while they run
5353
/// cleanup handlers. Deleting such a running sandbox should still complete
5454
/// promptly, rather than waiting out the runtime's termination grace period.
55+
//
56+
// Unignore this when the supervisor half of #5025 lands: on Podman the
57+
// supervisor container still waits out its stop timeout.
5558
#[testkit::test]
59+
#[ignore = "https://github.com/NVIDIA/OpenShell/issues/5025"]
5660
async fn delete_is_prompt_when_workload_is_slow_to_handle_term(
5761
cx: &mut Context,
5862
) -> testkit::Result {

0 commit comments

Comments
 (0)