Repository navigation
Fix comma operator discarding shadow/textShadow options in preprocess - #2915
Merged
Merged
Conversation
The two guards in StyleSheet/preprocess used the comma operator, so options.shadow and options.textShadow were evaluated and discarded: the shadow* to boxShadow and textShadow* to textShadow conversions ran whenever the legacy props were present, even when the caller disabled them through StyleSheet options. Use && as intended and cover the disabled path with tests. Fixes necolas#2914 Signed-off-by: Charan Rathore <[email protected]>
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
zoontek
approved these changes
Oct 21, 2026
Collaborator
|
Thanks for the fix! Two corrections to the description:
@necolas The |
Review nit from zoontek: match the spacing of the other describe blocks in this file. Signed-off-by: Charan Rathore <[email protected]>
Contributor
Author
|
Thanks, zoontek! The nit is pushed and the description now has both corrections. |
Collaborator
|
Thanks, I'm merging this. I might make some additional changes depending on @necolas's response. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The two shadow guards in
StyleSheet/preprocess.jsuse the comma operator:so
options.shadow/options.textShadoware evaluated and discarded. Theshadow*toboxShadowandtextShadow*totextShadowconversions run whenever the legacy props are present, even when the caller explicitly disables them through the StyleSheet options. Nothing insrcpassesfalsetoday, so this bug has no visible effect for users; only direct calls toStyleSheet(styles, { shadow: false })orpreprocess(style)see a change.Fix
Use
&&as intended, matching howStyleSheet/index.jsopts in withdefaultPreprocessOptions = { shadow: true, textShadow: true }. The existing shadow tests now pass that option explicitly (they previously relied on the comma bug), and new tests cover the disabled path: no options, or{ shadow: false }/{ textShadow: false }, removes the legacy props instead of converting them.Fixes #2914
Tests
jest packages/react-native-web/src/exports/StyleSheet: 91 passed, 51 snapshots.AI-assisted; Charan Rathore is the human driver.