Revert "Merge upstream changes that have occurred since the fork (#59)"#60
Revert "Merge upstream changes that have occurred since the fork (#59)"#60
Conversation
This reverts commit 0402edd. The final result in the main branch did not retain the merge commit, so trying to merge the `upstream/main` again now produces significant conflicts even though they should not be present.
|
cc @Ekleog-NEAR this is an interesting case where merge queue setup fails spectacularly. So originally I PRd a merge commit, pulling in |
|
@nagisa TBH I never understood why we squash-and-merge. This is already temporarily disabled on nearcore (because of the TOCTOU issue with reviews, see the bp issue thread on zulip), and it uses a merge commit there. I guess switching to merge commit everywhere might make sense for the reason you mention :) |
Linear history in the main branch is pretty darn nice. |
I mean there’s |
This reverts commit 0402edd.
The final result in the main branch did not retain the merge commit, so trying to merge the
upstream/mainagain now produces significant conflicts even though they should not be present.