feat(gas-keys): add DelegateV2 action type and nesting guard (1/3) by darioush · Pull Request #15883 · near/nearcore

darioush · 2026-06-09T19:09:12Z

First of a 3-PR stack splitting the gas-key DelegateV2 work. (original non-splitted: #15877)

Adds the Action::DelegateV2 wire type and its nesting guard, but does not execute it yet — validation rejects DelegateV2 (UnsupportedProtocolFeature) and the apply path fails it gracefully. Execution lands in the next PR in the stack.

Includes: SignedDelegateActionV2, the extensible DelegateActionExtension enum, Action::is_delegate (exhaustive, the single source of truth for the nesting guard, borsh reject set, and JSON schema filter), ActionView::DelegateV2, cost/fee handling, and the trivial match arms across the workspace. Rosetta left as TODO.

Co-authored-by: Copilot Autofix powered by AI <[email protected]>

Copilot

Pull request overview

This PR introduces a new on-wire action variant Action::DelegateV2 (for upcoming gas-keys meta-tx support), wires it through workspace match sites, and strengthens the “no nested delegate actions” guard by centralizing delegate-variant classification.

Changes:

Added SignedDelegateActionV2 + extensible DelegateActionExtension, and new Action::DelegateV2 variant with schema / borsh nesting guard updates.
Threaded DelegateV2 through runtime validation/apply paths (currently rejected via UnsupportedProtocolFeature) and fee/cost accounting recursion.
Added ActionView::DelegateV2 and minimal Rosetta adapter support mirroring existing Delegate operations.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tools/state-viewer/src/contract_accounts.rs	Adds `DelegateV2` to action-type classification for state viewer output.
runtime/runtime/src/pipelining.rs	Treats `DelegateV2` like `Delegate` in receipt preparation pipeline matching.
runtime/runtime/src/lib.rs	Fails `DelegateV2` gracefully in apply (returns `UnsupportedProtocolFeature` receipt-validation error).
runtime/runtime/src/config.rs	Extends fee/cost recursion to descend into `DelegateV2` inner actions; adds regression test.
runtime/runtime/src/actions.rs	Includes `DelegateV2` in permission/existence checks alongside `Delegate`.
runtime/runtime/src/action_validation.rs	Rejects `DelegateV2` during validation (until execution lands) and includes it in “only one delegate action” rule.
core/primitives/src/views.rs	Adds `ActionView::DelegateV2` view conversion (Action ⇄ ActionView).
core/primitives/src/errors.rs	Updates gas-key related access-key errors and introduces a new nonce-index error kind.
core/primitives/src/action/mod.rs	Adds `Action::DelegateV2` and `Action::is_delegate()` as an exhaustive delegate-style classifier.
core/primitives/src/action/delegate.rs	Implements `DelegateActionExtension`, `SignedDelegateActionV2`, and extends nesting guard + schema filtering + tests.
chain/rosetta-rpc/src/adapters/mod.rs	Adds interim Rosetta operation mapping for `DelegateV2` mirroring `Delegate`.
chain/client/src/pending_transaction_queue.rs	Ensures deploy-like detection recurses into `DelegateV2` inner actions.

Comments suppressed due to low confidence (1)

runtime/runtime/src/action_validation.rs:118

This "single delegate action" guard is manually matching Delegate/DelegateV2. Since Action::is_delegate() was added as the exhaustive source of truth for delegate-style variants, using it here avoids future bugs if another delegate variant is introduced but this match isn’t updated.

            if let Action::Delegate(_) | Action::DelegateV2(_) = action {
                if found_delegate_action {
                    return Err(ActionsValidationError::DelegateActionMustBeOnlyOne);
                }
                found_delegate_action = true;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

codecov · 2026-06-09T19:16:35Z

Codecov Report

❌ Patch coverage is 76.08696% with 55 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.89%. Comparing base (d65b028) to head (0dc2ee5).

Files with missing lines	Patch %	Lines
core/primitives/src/views.rs	0.00%	11 Missing ⚠️
runtime/runtime/src/lib.rs	0.00%	11 Missing ⚠️
core/primitives/src/action/mod.rs	38.46%	8 Missing ⚠️
core/primitives/src/action/delegate.rs	95.53%	5 Missing ⚠️
core/primitives/src/errors.rs	0.00%	5 Missing ⚠️
chain/rosetta-rpc/src/adapters/mod.rs	0.00%	4 Missing ⚠️
runtime/runtime/src/action_validation.rs	20.00%	4 Missing ⚠️
runtime/runtime/src/config.rs	93.75%	2 Missing and 2 partials ⚠️
chain/client/src/pending_transaction_queue.rs	0.00%	2 Missing ⚠️
tools/state-viewer/src/contract_accounts.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@                             Coverage Diff                              @@
##           darioush/gas-keys/reject-delegate-action   #15883      +/-   ##
============================================================================
- Coverage                                     69.90%   69.89%   -0.01%     
============================================================================
  Files                                           945      945              
  Lines                                        202339   202448     +109     
  Branches                                     202339   202448     +109     
============================================================================
+ Hits                                         141442   141503      +61     
- Misses                                        56143    56180      +37     
- Partials                                       4754     4765      +11

Flag	Coverage Δ
pytests-nightly	`1.11% <0.00%> (-0.01%)`	⬇️
unittests	`69.63% <76.08%> (+0.01%)`	⬆️
unittests-nightly	`69.58% <76.08%> (-0.04%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pugachAG · 2026-06-11T21:07:42Z

+    ProtocolSchema,
+)]
+#[cfg_attr(feature = "schemars", derive(schemars::JsonSchema))]
+pub struct SignedDelegateActionV2 {


could you please elaborate on why extension approach was chosen instead of introducing DelegateActionV2 with embedded gas key support? Then you introduce VesionedDelegateAction enum and replace all DelegateAction usage in runtime code with that. That seems like a more straightforward approach

The goal was to reduce duplication / boilerplate, and also avoid introducing a new signature distinguisher (SignableMessageType).

However I agree that introducing the VesionedDelegateAction is more consistent with the codebase.
This approach is attempted in this set of PRs: #15904 #15905 #15906 and I mark the prior set of PRs as draft for now.

Let me know if you prefer that approach.

…ions (1/3) (near#15904) First of a 3-PR stack adding gas-key support to meta transactions via a new `Action::DelegateV2`. Replaces the extension-based stack (near#15883, near#15884, near#15885) with the versioned design suggested in review there. Adds the wire types and the nesting guard, but no execution yet: validation rejects `DelegateV2` (`UnsupportedProtocolFeature`) and the apply path fails it gracefully. Execution lands in the next PR in the stack. Design: - `DelegateActionV2` mirrors `TransactionV1`: its `nonce: TransactionNonce` selects either the access key nonce or one of a gas key's parallel nonces by index. - `VersionedDelegateActionPayload` (wire enum, currently just `V2`) is the signed payload of `VersionedSignedDelegateAction`. Future versions add a variant here instead of a new `Action` variant, so the delegate nesting guard stays frozen, and the variant byte is covered by the signature so versions cannot be confused. - `DelegateV2` signs under its own NEP-461 discriminant (NEP-611, gas keys), making V1 and V2 signing domains disjoint by construction. - `VersionedDelegateActionRef`/`VersionedSignedDelegateActionRef` are borrowing wrappers for code handling V1 and V2 uniformly (the `VersionedActionReceipt` pattern). - A dedicated `ProtocolFeature::DelegateV2` (protocol version 85) gates the action independently of `ProtocolFeature::GasKeys`, so it can be pulled from the release on its own if needed. Includes `ActionView::DelegateV2`, cost/fee handling, and trivial match arms across the workspace. Protocol schema and openapi specs (1.2.11) are regenerated.

darioush and others added 4 commits June 8, 2026 17:38

fix(gas-keys): reject gas keys signing delegate actions

916fc3d

update openapi

f62084f

update protocol schema

bb9cff3

copilot's suggestion for casing

d65b028

Co-authored-by: Copilot Autofix powered by AI <[email protected]>

darioush requested a review from a team as a code owner June 9, 2026 19:09

darioush requested review from Copilot and ssavenko-near and removed request for a team June 9, 2026 19:09

Copilot started reviewing on behalf of darioush June 9, 2026 19:09 View session

This was referenced Jun 9, 2026

feat(gas-keys): gas-key nonce routing for DelegateV2 (2/3) #15884

Closed

feat(gas-keys): rosetta, mirror, prefetch support for DelegateV2 (3/3) #15885

Closed

Copilot AI reviewed Jun 9, 2026

View reviewed changes

Comment thread core/primitives/src/action/delegate.rs

Comment thread core/primitives/src/errors.rs

darioush changed the title ~~feat(gas-keys): add DelegateV2 action type and nesting guard~~ feat(gas-keys): add DelegateV2 action type and nesting guard (1/3) Jun 9, 2026

darioush marked this pull request as draft June 9, 2026 19:14

feat(gas-keys): add DelegateV2 action type and nesting guard

cc524e6

darioush force-pushed the darioush/gas-keys/delegate-v2-core-types branch from 67e0a4c to cc524e6 Compare June 9, 2026 19:24

darioush added 4 commits June 9, 2026 12:33

chore(gas-keys): chill comments (drop test docs, restore rosetta TODO)

5e15846

chore(gas-keys): TODO comment for inert DelegateV2 apply arm

4b70fde

chore(gas-keys): TODO comment for inert DelegateV2 validation arm

b22e57b

chore(gas-keys): regenerate openapi and protocol schema

0dc2ee5

darioush requested review from pugachAG and removed request for ssavenko-near June 9, 2026 20:09

darioush marked this pull request as ready for review June 9, 2026 20:23

darioush requested a review from frol as a code owner June 9, 2026 20:23

pugachAG reviewed Jun 11, 2026

View reviewed changes

Base automatically changed from darioush/gas-keys/reject-delegate-action to master June 11, 2026 21:50

darioush mentioned this pull request Jun 11, 2026

feat(gas-keys): add DelegateV2 action types for gas-key meta transactions (1/3) #15904

Merged

darioush marked this pull request as draft June 12, 2026 03:17

darioush closed this Jun 12, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(gas-keys): add DelegateV2 action type and nesting guard (1/3)#15883

feat(gas-keys): add DelegateV2 action type and nesting guard (1/3)#15883
darioush wants to merge 9 commits into
masterfrom
darioush/gas-keys/delegate-v2-core-types

darioush commented Jun 9, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Jun 9, 2026 •

edited

Loading

Uh oh!

pugachAG Jun 11, 2026

Uh oh!

darioush Jun 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

darioush commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pugachAG Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

darioush Jun 12, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

darioush commented Jun 9, 2026 •

edited

Loading

codecov Bot commented Jun 9, 2026 •

edited

Loading