feat(gas-keys): 4/n add gas key tests for Add/DeleteKey#14892
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14892 +/- ##
===========================================
+ Coverage 1.31% 68.72% +67.41%
===========================================
Files 722 916 +194
Lines 139818 199576 +59758
Branches 139818 199576 +59758
===========================================
+ Hits 1835 137155 +135320
+ Misses 137930 56501 -81429
- Partials 53 5920 +5867
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pugachAG
requested review from
attila0x2A and
pugachAG
and removed request for
walnut-the-cat
pugachAG
approved these changes
Jan 16, 2026
| access_key: AccessKey::gas_key_full_access(TEST_NUM_NONCES), | ||
| }; | ||
| action_add_key(&apply_state, state_update, account, &mut result, account_id, &action) | ||
| .expect("Expect ok"); |
Contributor
There was a problem hiding this comment.
just use unwrap, it will give pretty much this message
| }; | ||
| action_add_key(&apply_state, state_update, account, &mut result, account_id, &action) | ||
| .expect("Expect ok"); | ||
| assert!(result.result.is_ok(), "Result error: {:?}", result.result); |
Contributor
There was a problem hiding this comment.
nit: Result -> result, please update across all tests
| ); | ||
|
|
||
| let AccessKeyPermission::GasKeyFullAccess(gas_key_info) = &gas_key.permission else { | ||
| panic!("expected GasKeyFullAccess permission"); |
Contributor
There was a problem hiding this comment.
nit: since you are not logging any additional data here just use unreachable
| for i in 0..gas_key_info.num_nonces { | ||
| let gas_key_nonce = | ||
| get_gas_key_nonce(&state_update, &account_id, &gas_key_public_key, i) | ||
| .expect("Failed to get gas key nonce") |
Contributor
There was a problem hiding this comment.
same here: do not capitalize messages
| } | ||
|
|
||
| #[test] | ||
| fn test_view_gas_key_nonces() { |
Contributor
There was a problem hiding this comment.
nit: this test probably belongs as part of state_viewer module
Contributor
Author
There was a problem hiding this comment.
It seems too difficult to use the functions like add_gas_key_to_account from integration-tests/src/tests/runtime/state_viewer.rs (not sure if you meant another place)
darioush
force-pushed
the
darioush/gaskeys-updated/0.3-actions-query-alt
branch
from
9ff2975 to
f81a8f7
Compare
darioush
force-pushed
the
darioush/gaskeys-updated/0.4-new-tests-alt
branch
from
1eef728 to
61450be
Compare
darioush
force-pushed
the
darioush/gaskeys-updated/0.3-actions-query-alt
branch
from
4865576 to
e5a9172
Compare
Base automatically changed from
darioush/gaskeys-updated/0.3-actions-query-alt
to
master
January 19, 2026 15:05
darioush
force-pushed
the
darioush/gaskeys-updated/0.4-new-tests-alt
branch
from
d5abb64 to
e10648d
Compare
2 tasks
pull Bot
pushed a commit
to See887777/nearcore
that referenced
this pull request
Jun 3, 2026
# Gas Keys ([NEP-611](near/NEPs#611)) Gas keys are a new type of access key that carries a pre-funded NEAR balance and multiple independent nonce sequences. When a transaction is signed with a gas key, gas costs are deducted from the gas key's balance rather than the signer's account balance (deposits like NEAR transfers still come from the account). ## Why do we need gas keys? - Enabling SPICE without a DoS vector. The SPICE project (Separation of Execution from Consensus) decouples transaction execution from block production: transactions are included in blocks first, and executed asynchronously later. This means chunk producers can no longer verify account balances at inclusion time. An attacker could drain an account's balance in one transaction, then flood the chain with many transactions signed by that account. All would be accepted (since execution hasn't caught up), consuming block space for free when they inevitably fail. Gas keys close this gap by requiring gas to be pre-committed in the key itself, so chunk producers can verify gas availability without access to the latest state. - Parallel transaction submission. Today, programmatic users who submit many transactions in parallel must manage multiple access keys (each with its own nonce sequence). A gas key supports up to 1,024 independent nonce slots via a single key, removing that complexity. # Context - NEP (if exists): near/NEPs#611 - Implementation: - near#14868 - near#14869 - near#14883 - near#14891 - near#14892 - near#14911 - near#14924 - near#14925 - near#14930 - near#14933 - near#14969 - near#14985 - near#15033 - near#15034 - near#15067 - near#15068 - near#15100 - near#15101 - near#15186 # Testing and QA - unit tests - test-loop: https://github.com/near/nearcore/blob/master/test-loop-tests/src/tests/gas_keys.rs - forknet (automated): near#15207 - forknet (manual testing, planned) # Checklist - [x] Link to nightly nayduck run: https://nayduck.nearone.org/#/run/4756 - [x] Update CHANGELOG.md to include this protocol feature in the `Unreleased` section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a suite of tests for gas keys covering add, storage usage, deletion, and listing. Tests verify rejection of duplicate gas keys, conflicts with existing access keys, correct storage and nonce cleanup on deletion, proper errors when deleting non-existent gas keys, and removal of all gas keys when an account is deleted.
Added tests enforcing gas key protocol rules: too many nonces are rejected; function-call permissions with an allowance are rejected; and method name length limits are enforced.