Skip to content

feat: Added the ability to select multiple keys to remove from the account#597

Merged
r-near merged 1 commit into
mainfrom
construct-transaction-delete-keys
May 28, 2026
Merged

feat: Added the ability to select multiple keys to remove from the account#597
r-near merged 1 commit into
mainfrom
construct-transaction-delete-keys

Conversation

@FroVolod

@FroVolod FroVolod commented May 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator
Screenshot 2026-05-26 at 17 32 15

@github-project-automation github-project-automation Bot moved this to NEW❗ in DevTools May 26, 2026
@FroVolod FroVolod marked this pull request as ready for review May 27, 2026 10:54
@FroVolod FroVolod requested a review from a team as a code owner May 27, 2026 10:54
@FroVolod

FroVolod commented May 27, 2026

Copy link
Copy Markdown
Collaborator Author

@race-of-sloths

@race-of-sloths

race-of-sloths commented May 27, 2026 •
edited
Loading

Copy link
Copy Markdown

@FroVolod Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Weekly streak is on the road, smart strategy! Secure your streak with another PR!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@race-of-sloths 2

Your contribution is much appreciated with a final score of 2!
You have received 37 (20 base + 15 weekly bonus + 5% lifetime bonus) Sloth points for this contribution

Another weekly streak completed, well done @FroVolod! To keep your weekly streak and get another bonus make pull request next week! Looking forward to see you in race-of-sloths

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths and receive a reward
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@r-near r-near requested a review from Copilot May 27, 2026 20:45
Copilot AI reviewed May 27, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the transaction construction/reconstruction flows to support deleting multiple access keys in a single constructed transaction by accepting/selecting a list of public keys and expanding it into multiple DeleteKey actions.

Changes:

  • Update construct-transaction “delete-key” action to accept a PublicKeyList and expand it into multiple DeleteKey actions.
  • Reuse the existing account delete-keys public-key selection UX (multi-select/online + manual/offline) from within the transaction construction flow.
  • Update reconstruct-transaction mapping to populate the new public_keys field when reconstructing a DeleteKey action.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/commands/transaction/reconstruct_transaction/mod.rs Adjusts reconstructed CLI action to use public_keys list for DeleteKey.
src/commands/transaction/construct_transaction/mod.rs Adds context conversion to reuse the account delete-keys key selector during transaction construction.
src/commands/transaction/construct_transaction/add_action_1/add_action/delete_key/mod.rs Switches delete-key input to PublicKeyList, expands into multiple actions, and hooks custom input.
src/commands/transaction/construct_transaction/add_action_2/add_action/delete_key/mod.rs Same multi-key delete-key support for step 2 of the action-building flow.
src/commands/transaction/construct_transaction/add_action_3/add_action/delete_key/mod.rs Same multi-key delete-key support for step 3 of the action-building flow.
src/commands/account/mod.rs Exposes delete_key module to allow reuse from transaction construction.
src/commands/account/delete_key/mod.rs Exposes selector module/context fields needed for reuse by transaction construction.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/commands/transaction/construct_transaction/mod.rs
@r-near r-near merged commit 2b5bdf9 into main May 28, 2026
15 checks passed
@r-near r-near deleted the construct-transaction-delete-keys branch May 28, 2026 16:42
@github-project-automation github-project-automation Bot moved this from NEW❗ to Shipped 🚀 in DevTools May 28, 2026
@race-of-sloths

race-of-sloths commented May 28, 2026

Copy link
Copy Markdown

🥁 Score it!

@r-near, please score the PR with @race-of-sloths score [1/2/3/5/8/13]. The contributor deserves it.
If no scoring is provided within 24 hours, this PR will be scored as 2 🦥

@nearprotocol-ci nearprotocol-ci mentioned this pull request May 28, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@r-near r-near r-near approved these changes

Assignees

No one assigned

Labels

None yet

Projects

DevTools
Status: Shipped 🚀

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@FroVolod @race-of-sloths @r-near @thisisjoshford