feat: validate receiver account before sending tokens by Gmin2 · Pull Request #582 · near/near-cli-rs

Gmin2 · 2026-04-02T10:36:55Z

Adds recipient validation to the tokens subcommand (send-near, send-ft,send-ft-call, send-nft), after network selection, two checks run: a network mismatch check that warns if the receiver looks like it belongs to a different network and an rpc existence check that warns if the receiver account doesn't exist on the selected network. Both checks prompt the user for confirmation and never block, the user can always choose to proceed. If the rpc is unreachable,the existence check is skipped silently.

Fixes #581

Copilot

Pull request overview

This PR adds receiver account validation for token transfer commands to reduce accidental sends to the wrong network or to non-existent accounts, while still allowing users to proceed after explicit confirmation.

Changes:

Added common helper(s) to (1) warn on likely network mismatch and (2) check receiver existence via RPC with a confirmation prompt.
Wired the receiver validation into tokens send flows (NEAR, FT, FT-call, NFT) after network selection.
Implemented “cancel” behavior by returning an empty-actions transaction (which the existing pipeline treats as a cancellation).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/common.rs	Adds network-mismatch heuristic, RPC existence check, and shared confirmation prompt helper.
src/commands/tokens/send_near/mod.rs	Calls receiver validation before creating the transfer transaction.
src/commands/tokens/send_nft/mod.rs	Calls receiver validation before constructing the NFT transfer call.
src/commands/tokens/send_ft/amount_ft.rs	Calls receiver validation before building FT transfer transaction.
src/commands/tokens/send_ft_call/amount_ft.rs	Calls receiver validation before building FT transfer-call transaction.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-02T10:41:32Z

+            receiver_account_id, network_config.network_name
+        );
+        return ask_if_should_proceed();
+    }
+


The early return ask_if_should_proceed() means that when the receiver looks like it’s on the wrong network and the user chooses to proceed, the RPC existence check is never run. If the intention is to run both validations (as described in the PR description), consider prompting on the network-mismatch warning and then continuing to the existence check when the user confirms.

Copilot · 2026-04-02T10:41:33Z

+        .block_on(get_account_state(
+            network_config,
+            receiver_account_id,
+            near_primitives::types::BlockReference::latest(),
+        ));


This function performs an RPC call via get_account_state unconditionally. In offline mode (GlobalContext.offline), this will still retry (with sleeps) and slow down “offline” flows. Consider adding an offline flag parameter (or passing GlobalContext) so the existence check can be skipped when offline, while still keeping the lightweight network-suffix heuristic.

done (3490ab9)

Copilot · 2026-04-02T10:41:33Z

+            ask_if_should_proceed()
+        }
+        // Dont block the transaction if we can't reach the RPC
+        Err(_) => Ok(true),


Err(_) => Ok(true) will silently proceed not only when the RPC is unreachable, but also for other server-side errors (e.g., misconfigured RPC URL, unexpected server response). This can hide real problems. Consider matching specifically on JsonRpcError::TransportError(_) (skip silently as intended) and returning Err(err.into()) for other error variants, similar to how account existence is handled in create_account/fund_myself_create_account/sign_as.

Suggested change

Err(_) => Ok(true),

Err(near_jsonrpc_client::errors::JsonRpcError::TransportError(_)) => Ok(true),

Err(err) => Err(err.into()),

Copilot · 2026-04-02T10:41:33Z

+            );
+            ask_if_should_proceed()
+        }
+        // Dont block the transaction if we can't reach the RPC


Typo in comment: "Dont" → "Don't".

Suggested change

// Dont block the transaction if we can't reach the RPC

// Don't block the transaction if we can't reach the RPC

FroVolod · 2026-04-02T11:38:20Z

+                            actions: vec![],
+                        });
+                    }
+


You cannot use the user dialog in fn from previous context(). Some users use a script command that should end with "quiet".

Added a verbosity param in validate_receiver_account_id to skip validation if in quiet mode to skip validation in fcb7f73

FroVolod · 2026-04-02T11:40:54Z

+                    });
+                }
+
                let amount_ft = if let crate::types::ft_properties::FungibleTokenTransferAmount::ExactAmount(ft) = &ft_transfer_amount {


Same reason as above

FroVolod · 2026-04-02T11:41:55Z

+                            receiver_id: receiver_account_id.clone(),
+                            actions: vec![],
+                        });
+                    }


Same reason as above

FroVolod · 2026-04-02T11:42:22Z

+                            receiver_id: nft_contract_account_id.clone(),
+                            actions: vec![],
+                        });
+                    }


Same reason as above

frolvanya

Thanks for the contribution!

Found few minor issues, but overall looks good to me. Still probably have to be discussed with a team which option rpc vs string check is better

Co-authored-by: Copilot <[email protected]>

vsavchyn-dev

LGTM, thanks for the PR!

## 🤖 New release * `near-cli-rs`: 0.26.1 -> 0.26.2 (✓ API compatible changes) <details><summary>Changelog</summary> <blockquote> ## [0.26.2](v0.26.1...v0.26.2) - 2026-05-08 ### Added - validate receiver account before sending tokens ([#582](#582)) </blockquote> </details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/).

Gmin2 requested a review from a team as a code owner April 2, 2026 10:36

Copilot AI review requested due to automatic review settings April 2, 2026 10:36

thisisjoshford added this to DevTools Apr 2, 2026

github-project-automation Bot moved this to NEW❗ in DevTools Apr 2, 2026

Copilot started reviewing on behalf of Gmin2 April 2, 2026 10:37 View session

feat: validate receiver account before sending tokens

a22d122

Gmin2 force-pushed the feat/validate-receiver-before-send branch from ea800ee to a22d122 Compare April 2, 2026 10:40

Copilot AI reviewed Apr 2, 2026

View reviewed changes

FroVolod reviewed Apr 2, 2026

View reviewed changes

fix: added verbosity param to skip validation in quiet mode

fcb7f73

Gmin2 requested a review from FroVolod April 2, 2026 12:59

frolvanya reviewed Apr 2, 2026

View reviewed changes

Comment thread src/common.rs Outdated

Comment thread src/common.rs Outdated

frolvanya reviewed Apr 2, 2026

View reviewed changes

Comment thread src/common.rs Outdated

Comment thread src/common.rs Outdated

Comment thread src/common.rs

FroVolod added 3 commits April 30, 2026 08:54

replaced eprintln! with tracing::warn!

5e81a71

added tracing::instrument

bafbb55

fixed

972b650

FroVolod marked this pull request as draft April 30, 2026 14:08

FroVolod and others added 2 commits May 1, 2026 12:28

refactored

3490ab9

Co-authored-by: Copilot <[email protected]>

Merge branch 'main' into feat/validate-receiver-before-send

38b9244

FroVolod marked this pull request as ready for review May 1, 2026 09:35

frolvanya approved these changes May 1, 2026

View reviewed changes

vsavchyn-dev approved these changes May 7, 2026

View reviewed changes

vsavchyn-dev merged commit 6f35092 into near:main May 8, 2026
13 checks passed

github-project-automation Bot moved this from NEW❗ to Shipped 🚀 in DevTools May 8, 2026

nearprotocol-ci mentioned this pull request May 8, 2026

chore: release v0.26.2 #590

Merged

	Err(_) => Ok(true),
	Err(near_jsonrpc_client::errors::JsonRpcError::TransportError(_)) => Ok(true),
	Err(err) => Err(err.into()),

	// Dont block the transaction if we can't reach the RPC
	// Don't block the transaction if we can't reach the RPC

Uh oh!

Conversation

Gmin2 commented Apr 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

FroVolod May 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

FroVolod Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Gmin2 Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FroVolod Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

FroVolod Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

FroVolod Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

frolvanya left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vsavchyn-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Gmin2 Apr 2, 2026 •

edited

Loading