chore: bump near crates to 0.35.0#580
Merged
Merged
Conversation
…TTP calls
Tests were failing because prepare_tests() used unsafe set_var() to set
HOME/XDG_CONFIG_HOME across parallel test threads (undefined behavior).
Combined with blocking HTTP calls to nearblocks API added at startup in
- Pass env vars explicitly to subprocess Command instead of set_var
- Pre-create ft_contracts.json in test setup to skip startup HTTP calls
- Simplify is_used_ft_contract_account_list_exist to just check file existence
- Write valid empty JSON ("[]") instead of empty file on API failure
…t config - Remove else branch that wrote empty [] on fetch failure, so the CLI retries on the next run instead of caching an empty list permanently - Place test config at the correct platform-specific path for macOS
- Bump near-crypto, near-primitives, near-jsonrpc-primitives to 0.35.0-rc.5 - Use git dep for near-jsonrpc-client (pending near/near-jsonrpc-client-rs#186) - Use path dep for near-socialdb-client (pending crate bump) - Add match arms for new PGas enum variants: - AccessKeyPermissionView::GasKeyFunctionCall/GasKeyFullAccess - Action::TransferToGasKey/WithdrawFromGasKey - ActionView::TransferToGasKey/WithdrawFromGasKey - ActionErrorKind gas key error variants - InvalidTxError gas key error variants - ActionsValidationError gas key validation variants - Handle TransactionNonce type (replacing raw u64 nonce)
r-near
force-pushed
the
bump-near-crates-0.35
branch
from
6e84c7b to
88af88d
Compare
Points to r-near/near-socialdb-client-rs#bump-near-crates-0.35 pending near/near-socialdb-client-rs#39.
r-near
added a commit
to near/cargo-near
that referenced
this pull request
Mar 31, 2026
- Bump near-primitives from 0.34 to 0.35.0-rc.5 - Use git dep for near-cli-rs pending near/near-cli-rs#580 - Adapt random_account_id to accept GlobalContext (near-cli-rs API change)
r-near
changed the title
vsavchyn-dev
reviewed
Apr 6, 2026
vsavchyn-dev
previously approved these changes
Apr 6, 2026
vsavchyn-dev
dismissed
their stale review
Cargo.toml needs pointing to the release of jsonrpc
Co-authored-by: Vladyslav Savchyn <[email protected]>
…r-socialdb-client
Contributor
There was a problem hiding this comment.
Pull request overview
Bumps NEAR-related Rust crates to 0.35.0 (and related deps) and updates the CLI to handle new “gas key” transaction/action/permission types introduced in near-primitives 0.35, including updated transaction nonce handling.
Changes:
- Update nonce handling to support
TransactionNonce(extract inner nonce for legacyu64fields, especially delegate actions). - Add CLI rendering for new gas key actions/permissions and map new error variants to user-friendly messages.
- Bump NEAR crate versions and introduce temporary git dependencies for unreleased upstream changes.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/types/transaction.rs |
Extract inner nonce when converting to legacy TransactionV0. |
src/transaction_signature_options/sign_with_legacy_keychain/mod.rs |
Refactor access-key filtering logic for keychain selection. |
src/transaction_signature_options/sign_with_ledger/mod.rs |
Extract inner nonce for delegate-action signing paths (USB/BLE). |
src/transaction_signature_options/mod.rs |
Extract inner nonce when creating DelegateAction. |
src/common.rs |
Add gas-key action output, gas-key permission display, and new error mappings; adjust nonce formatting. |
src/commands/transaction/reconstruct_transaction/mod.rs |
Explicitly reject gas-key actions/permissions during reconstruction (not yet supported). |
src/commands/account/get_public_key/from_legacy_keychain/mod.rs |
Refactor access-key filtering logic for keychain selection. |
src/commands/account/export_account/mod.rs |
Exclude gas-key permissions from exportable key selection. |
src/commands/account/delete_key/public_keys_to_delete.rs |
Add display formatting for gas-key permissions in delete-key selection UI. |
Cargo.toml |
Bump NEAR crates to 0.35 and switch near-socialdb-client to a temporary git dependency. |
Cargo.lock |
Lockfile updates reflecting dependency bumps and git-sourced crates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vsavchyn-dev
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AccessKeyPermissionView::GasKeyFunctionCall/GasKeyFullAccess— display gas key info in account summaries and key listingsAction::TransferToGasKey/WithdrawFromGasKey— display in transaction previewsActionView::TransferToGasKey/WithdrawFromGasKey— display in successful transaction outputActionErrorKind,InvalidTxError,ActionsValidationError— user-friendly error messagesTransactionNonceenum replacing rawu64nonce — extract inner nonce for delegate actions and display formatting