Skip to content
This repository was archived by the owner on Oct 4, 2024. It is now read-only.

Fix Check for Existing Beneficiary in Account Deletion & Repair CI#1009

Merged
volovyks merged 9 commits into
masterfrom
fix-account-exist-check
Aug 4, 2022
Merged

Fix Check for Existing Beneficiary in Account Deletion & Repair CI#1009
volovyks merged 9 commits into
masterfrom
fix-account-exist-check

Conversation

@idea404

@idea404 idea404 commented Aug 3, 2022

Copy link
Copy Markdown
Contributor

This PR seeks to address the following two unaddressed subjects from #999:

  1. The conditional check during deleteAccount() now ultimately performs a view_account RPC call instead of searching for keys to determine whether a ben. account exists
  2. The test bash script is now fixed (allowing CI to pass) as deleting an account now requires user confirmation

@idea404 idea404 requested a review from volovyks August 3, 2022 17:30
@idea404 idea404 added enhancement New feature or request bug Something isn't working labels Aug 3, 2022
@volovyks volovyks merged commit e0ffe89 into master Aug 4, 2022
@idea404 idea404 deleted the fix-account-exist-check branch August 5, 2022 08:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants