fix: borsh reconstruction#1886
Merged
Merged
Conversation
When borsh deserializes a transaction, it returns the public key as a plain object. This makes that, if you serialize the transaction, then deserialize it, you will see an object that respects the public key interface, but does NOT implement its methods, causing problems down the line
🦋 Changeset detectedLatest commit: e66ad60 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
added 3 commits
March 5, 2026 19:42
denbite
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When borsh deserializes a transaction, it returns the public key as a plain object. This makes that, if you serialize the transaction, then deserialize it, you will see an object that respects the public key interface, but does NOT implement its methods, causing problems down the line
Pre-flight checklist
pnpm changesetto create achangesetJSON document appropriate for this change.