fix: improve provider method signatures and parseNearAmount type safety#1691
Merged
denbite merged 7 commits intoNov 19, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: f8666a0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
- Make parseNearAmount parameter required (no longer accepts undefined) - Add default wait_until='EXECUTED_OPTIMISTIC' for viewTransactionStatus - Add default wait_until='EXECUTED_OPTIMISTIC' for viewTransactionStatusWithReceipts - Rename viewValidatorsV2 back to viewValidators with improved signature - Update test to remove invalid null test case for parseNearAmount
r-near
force-pushed
the
claude/fix-provider-methods-01TgkqVGDDxH2PrcaAgYXH69
branch
from
414de17 to
34d1fc3
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
|
@r-near changeset file is needed |
denbite
requested changes
Nov 18, 2025
- Add empty string validation after cleanupAmount to throw an error - Prevents dangerous behavior where empty form fields would be treated as 0 NEAR - Add tests for empty string, whitespace, and comma-only inputs - Add changeset file documenting breaking changes
r-near
requested review from
andy-haynes,
frol and
morgsmccauley
as code owners
denbite
deleted the
claude/fix-provider-methods-01TgkqVGDDxH2PrcaAgYXH69
branch
Merged
This was referenced Nov 19, 2025
This was referenced Jan 19, 2026
Closed
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
pnpm changesetto create achangesetJSON document appropriate for this change.Motivation
Test Plan
Related issues/PRs