Skip to content

fix: move keyToImplicitAddress to @near-js/crypto#1662

Merged
denbite merged 3 commits into
masterfrom
break_cycle_dependency_between_utils_and_crypto
Nov 6, 2025
Merged

fix: move keyToImplicitAddress to @near-js/crypto#1662
denbite merged 3 commits into
masterfrom
break_cycle_dependency_between_utils_and_crypto

Conversation

@denbite

@denbite denbite commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • Commit messages follow the conventional commits spec
  • If this is a code change: I have written unit tests.
  • If this changes code in a published package: I have run pnpm changeset to create a changeset JSON document appropriate for this change.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Related issues/PRs

@changeset-bot

changeset-bot Bot commented Nov 5, 2025 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: bba4594

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@near-js/crypto Patch
@near-js/utils Patch
near-api-js Patch
@near-js/cookbook Patch
@near-js/accounts Patch
@near-js/biometric-ed25519 Patch
@near-js/client Patch
@near-js/iframe-rpc Patch
@near-js/keystores-browser Patch
@near-js/keystores-node Patch
@near-js/keystores Patch
@near-js/providers Patch
@near-js/signers Patch
@near-js/tokens Patch
@near-js/transactions Patch
@near-js/types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation Bot moved this to NEW❗ in DevTools Nov 5, 2025
@denbite denbite enabled auto-merge November 5, 2025 18:30
gagdiez
gagdiez requested changes Nov 6, 2025
View reviewed changes

@gagdiez gagdiez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are definitively not going to duplicate a function that was introduced on 2.5.0 on 2.5.1

either we move it from one package to another, or we simply do nothing

@gagdiez gagdiez changed the title fix: add duplicate of keyToImplicitAddress to @near-js/crypto fix: move keyToImplicitAddress to @near-js/crypto Nov 6, 2025
@denbite denbite merged commit 5f5a6a5 into master Nov 6, 2025
3 checks passed
@denbite denbite deleted the break_cycle_dependency_between_utils_and_crypto branch November 6, 2025 11:41
@github-project-automation github-project-automation Bot moved this from NEW❗ to Shipped 🚀 in DevTools Nov 6, 2025
@github-actions github-actions Bot mentioned this pull request Nov 6, 2025
Merged
@gagdiez gagdiez mentioned this pull request Nov 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gagdiez gagdiez gagdiez approved these changes

Assignees

No one assigned

Labels

None yet

Projects

DevTools
Status: Shipped 🚀

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@denbite @gagdiez @thisisjoshford