Repository navigation
fix(server): authorize upstream's server.checkSecretSource RPC (red main) - #68
Merged
Merged
Conversation
…the 2026-11-13 sync The nightly sync (415dd48) brought upstream's new server.checkSecretSource (pingdotgg#31723). The fork's snapshot of authorized upstream RPCs lacked it, so wsMountedRpc.test.ts failed on main. Co-Authored-By: Claude Opus 5.5 <[email protected]>
github-actions
Bot
added
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main is red since the nightly upstream sync 415dd48 (2026-11-13):
apps/server/src/wsMountedRpc.test.tsfailed because upstream added the RPCserver.checkSecretSource(pingdotgg#31723, "check a secret reference before saving it") and the fork's snapshotauthorizedUpstreamWsRpcTags.jsondid not list it. The other test in that file already accepts it as an official upstream RPC.Fix: add
server.checkSecretSourceto the snapshot. The test passes locally (2/2).Main's Test Server 8 also failed once on an upstream Kiro replay test that timed out after 240 s (
KiroReplayFixtures.integration.test.ts, provider_thread_resume/kiro); this PR's CI shows whether that repeats.🤖 Generated with Claude Code