You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 6f38b8d
Browse filesBrowse the repository at this point in the historyBrowse files
fix(repo): run test workers without node's baseline compiler
A V8 garbage-collector crash in the baseline compiler (Sparkplug) of
Node 24 can kill a test worker with SIGSEGV while no test has failed
(upstream, nodejs/node#62393). It was seen in the tokens suite. Every
package's vitest config now passes --no-sparkplug to its workers through
execArgv, and `scripts:test` runs `node --no-sparkplug --test`, which
hands the flag on to each test file's process. The browser config is
left alone: its tests run in Chromium, not in Node.
NODE_OPTIONS cannot carry the flag, because Node refuses V8 options
outside a short allow list there, so pnpm's node-options setting was not
an option. A tokens test asserts the flag reaches a worker, and a check
in scripts reads every package's vitest config so a new package cannot
leave it out.
Remove the flag from the configs and from `scripts:test` once the
pinned Node carries the V8 fix.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
0 commit comments