Repository navigation
Commit ad11919
committed
Lock pytest 9.0.3 to keep conftest fixtures
pytest 9.1.0 and 9.1.1 bind a conftest's fixtures to the first Package
node collected for its directory. A later file argument sitting
directly in the parent directory re-collects that parent and creates a
second Package node for the same path, so tests collected through it
silently lose the conftest's autouse fixtures (pytest-dev/pytest#14635).
Here that dropped tests/unit/reconciler/conftest.py's JIRA_PROJECT=DIG
pin for tests/unit/reconciler/orchestrate whenever a run listed a
tests/unit/reconciler path, then a tests/unit-level file such as
test_raw_git_write_lint.py, then the orchestrate directory. 22 reconcile
tests then failed on an empty Jira project. The failure looked
concurrency-dependent only because the serial and paired re-runs never
used that argument order.
Exclude the affected releases from the dev extra and lock pytest
9.0.3, the newest release without the defect. 9.2.0 fixes #14635 but
is not usable yet: its monkeypatch undo deletes starlette State
attributes (pytest-dev/pytest#15099, still open), failing 6 review-bot
tests, and it crashes mutmut 3.7.0's stats run (boxed/mutmut#615).
Add a regression test that runs the installed pytest on a throwaway
project with the same argument shape.
rebar-ticket: 81da-a1b4-bf29-4ad2
Signed-off-by: Rebar Bot Nava <[email protected]>
Change-Id: Id46287a91216a9898d5300014cc52fb3dd89f16b1 parent 374cc2f commit ad11919
3 files changed
Lines changed: 94 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
237 | 237 | | |
238 | 238 | | |
239 | 239 | | |
240 | | - | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
241 | 246 | | |
242 | 247 | | |
243 | 248 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments