make sure all pinned code is commented for easy access

scottf · scottf · commit 96d2e9f4e3d5 · 2025-09-25T10:19:36.000-04:00
diff --git a/src/main/java/io/nats/client/PullRequestOptions.java b/src/main/java/io/nats/client/PullRequestOptions.java
@@ -60,12 +60,14 @@ public String toJson() {
         JsonUtils.addFieldAsNanos(sb, IDLE_HEARTBEAT, idleHeartbeat);
         JsonUtils.addField(sb, GROUP, group);
         JsonUtils.addFieldWhenGtZero(sb, PRIORITY, priority);
+// TODO - PINNED CONSUMER SUPPORT
 //        JsonUtils.addField(sb, ID, getPinId());
         JsonUtils.addField(sb, MIN_PENDING, minPending);
         JsonUtils.addField(sb, MIN_ACK_PENDING, minAckPending);
         return JsonUtils.endJson(sb).toString();
     }
 
+// TODO - PINNED CONSUMER SUPPORT
 //    protected String getPinId() {
 //        return null;
 //    }
diff --git a/src/main/java/io/nats/client/api/PriorityGroupState.java b/src/main/java/io/nats/client/api/PriorityGroupState.java
@@ -31,13 +31,13 @@ public class PriorityGroupState {
 //    private final String pinnedClientId;
 //    private final ZonedDateTime pinnedTime;
 
-
     static List<PriorityGroupState> optionalListOf(JsonValue vpgStates) {
         return JsonValueUtils.optionalListOf(vpgStates, PriorityGroupState::new);
     }
 
     PriorityGroupState(JsonValue vpgState) {
         group = JsonValueUtils.readString(vpgState, GROUP);
+// TODO - PINNED CONSUMER SUPPORT
 //        pinnedClientId = JsonValueUtils.readString(vpgState, PINNED_CLIENT_ID);
 //        pinnedTime = readDate(vpgState, PINNED_TS);
     }
@@ -51,6 +51,7 @@ public String getGroup() {
         return group;
     }
 
+// TODO - PINNED CONSUMER SUPPORT
 //    /**
 //     * The generated ID of the pinned client
 //     * @return the id
@@ -60,6 +61,7 @@ public String getGroup() {
 //        return pinnedClientId;
 //    }
 
+// TODO - PINNED CONSUMER SUPPORT
 //    /**
 //     * The timestamp when the client was pinned
 //     * @return the timestamp
@@ -73,6 +75,7 @@ public String getGroup() {
     public String toString() {
         return "PriorityGroupState{" +
             "group='" + group + '\'' +
+// TODO - PINNED CONSUMER SUPPORT
 //            ", pinnedClientId='" + pinnedClientId + '\'' +
 //            ", pinnedTime=" + pinnedTime +
             '}';
diff --git a/src/main/java/io/nats/client/api/SuccessApiResponse.java b/src/main/java/io/nats/client/api/SuccessApiResponse.java
@@ -23,16 +23,12 @@ public class SuccessApiResponse extends ApiResponse<SuccessApiResponse> {
 
     public SuccessApiResponse(Message msg) {
         super(msg);
-        success = readBoolean(jv, SUCCESS);
-    }
-
-    public SuccessApiResponse(Message msg, boolean successWhenNotError) {
-        super(msg);
-        if (successWhenNotError) {
+        Boolean b = readBoolean(jv, SUCCESS, null);
+        if (b == null) {
             success = !hasError();
         }
         else {
-            success = readBoolean(jv, SUCCESS);
+            success = b;
         }
     }
 
diff --git a/src/main/java/io/nats/client/impl/NatsJetStreamManagement.java b/src/main/java/io/nats/client/impl/NatsJetStreamManagement.java
@@ -374,7 +374,7 @@ public boolean deleteMessage(String streamName, long seq, boolean erase) throws
 //        String subj = String.format(JSAPI_CONSUMER_UNPIN, streamName, consumerName);
 //        byte[] payload = String.format("{\"group\": \"%s\"}", consumerGroup).getBytes();
 //        Message resp = makeRequestResponseRequired(subj, payload, getTimeout());
-//        return new SuccessApiResponse(resp, true).throwOnHasError().getSuccess();
+//        return new SuccessApiResponse(resp).throwOnHasError().getSuccess();
 //    }
 
     /**
diff --git a/src/main/java/io/nats/client/support/NatsJetStreamConstants.java b/src/main/java/io/nats/client/support/NatsJetStreamConstants.java
@@ -125,7 +125,8 @@ public interface NatsJetStreamConstants {
     String NATS_BATCH_SEQUENCE_HDR  = "Nats-Batch-Sequence";
     String NATS_BATCH_COMMIT_HDR    = "Nats-Batch-Commit";
 
-    String NATS_PIN_ID_HDR = "Nats-Pin-Id";
+// TODO - PINNED CONSUMER SUPPORT
+//    String NATS_PIN_ID_HDR = "Nats-Pin-Id";
 
     int JS_CONSUMER_NOT_FOUND_ERR = 10014;
     int JS_NO_MESSAGE_FOUND_ERR = 10037;

Original file line number	Diff line number	Diff line change
`@@ -23,16 +23,12 @@ public class SuccessApiResponse extends ApiResponse<SuccessApiResponse> {`
`23`	`23`
`24`	`24`	`public SuccessApiResponse(Message msg) {`
`25`	`25`	`super(msg);`
`26`		`- success = readBoolean(jv, SUCCESS);`
`27`		`- }`
`28`		`-`
`29`		`- public SuccessApiResponse(Message msg, boolean successWhenNotError) {`
`30`		`- super(msg);`
`31`		`- if (successWhenNotError) {`
	`26`	`+ Boolean b = readBoolean(jv, SUCCESS, null);`
	`27`	`+ if (b == null) {`
`32`	`28`	`success = !hasError();`
`33`	`29`	`}`
`34`	`30`	`else {`
`35`		`- success = readBoolean(jv, SUCCESS);`
	`31`	`+ success = b;`
`36`	`32`	`}`
`37`	`33`	`}`
`38`	`34`