Repository navigation
fix(paper): refuse malformed preflight collections - #999
Merged
seathatflowsinourveins merged 2 commits intoOct 11, 2026
Merged
Conversation
seathatflowsinourveins
marked this pull request as ready for review
October 11, 2026 07:32
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
seathatflowsinourveins
deleted the
foundation/paper-raw-list-guards-20261011
branch
October 11, 2026 07:38
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Adaptive paper reads could treat HTTP 200 positions or open-orders
{}and JSON""as empty collections. Preflight now requires exact lists for both endpoints,and snapshot collection requires an exact positions list before normalization.
A malformed snapshot freezes admissions and raises the existing sanitized
TransportError, so it cannot become a complete flat-account observation.65cf2730068429a1c48c8c18fb24aadef8120817lane:foundationtransport.py,README-transport.md,source-hashes.json, transport tests andmanifests/evidence.json.011533390e03782bcdef10aac3626e7d8e07b444, directly on9b690191e07bafa779bf4c0e5330ed789360243e; one commit closes the sharedClaude/GPT snapshot P2.
SOTA sources
commit
cc4cb3b7ba50ae250e621983c2779047fb16bb28:TradingClient.get_all_positionsraw returnreturns the unchecked response with
raw_data=True;RESTClient._one_requestJSON decoderreturns successful decoded JSON. Native SDK HTTP/JSON handling is retained;
the application checks the collection contract before normalization.
client/rest files have equal bytes; the live v0.44.0 tag resolves to this commit.
The next review packet includes
UPSTREAM-PINS.json, bothUPSTREAM-SRC-*.pyfiles andUPSTREAM-TAG.json.Evidence-class table
{}and JSON""at both collection endpoints[]control passes{}and JSON""9b690191transport bytes; valid[]control passesLocal commands run
checks.pyand its exact argv/cwd/timing/return-code/output-hash receipts areretained in
reviews/pr999-final-20261011T062518Z/in lane coordination state.The real SDK HTTP boundary is patched to local successful responses; no broker
or credential-runner operation is involved. JSON null is sent as the bytes
null; tuple and list-subclass controls are SDK-return surrogates that cannotarise from ordinary JSON decoding. The nine baseline failures include four
empty iterable bypasses and five already-refused shapes whose refusal context
now identifies the explicit list guard. Initial probe setup errors are retained
separately and excluded from fail-before claims.
The synthetic merged commit is used only for local verification; the branch
remains the one forward commit on
9b690191. The review's separate existingopen_orders_completeconsumer marker limitation and preflight malformed-row/invalid-JSON exception sanitization remain follow-ups. Historical broker
qualification is not rerun by these fixture checks.
The genuine merged worktree also runs the archive-dependent runner187,
market-research45, workflow-hardening112 and policy-grants21 modules: 365 methods
reported, no failures/errors, three workflow skips. Two skips require PyYAML in
the SDK runtime; both exact controls separately pass under native Python3.13.16
with installed PyYAML6.0.3. The remaining skip has no hash-frozen workflow to
test. The requested 195-test matrix has zero skips in both trees. These runs
resolve the named archive/Git and YAML controls; no whole-repository test pass
is claimed.
Decision record
blueprints/us-equities/adaptive-paper/README-transport.mdrecords the responsecontract and pinned mechanism, including the corrected decoder locator. Keep
the exact-list boundary while native raw-data calls return unchecked JSON;
reconsider it if the adopted SDK validates these collections before returning.
Checklist