Repository navigation
docs: ai-memory --capture-assistant was not in force on this host (correction #149) - #997
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 805aca0164
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…rrection #149) The maintenance doc said the allowlist installers carried --capture-assistant. 0 of 9 Claude and 0 of 7 Codex hook commands did: ai-memory bakes the flag only into the Stop command and only preserves an opt-in already present (install_hooks.rs:689-701, 1104-1109 @ 89bd8ded; render_shared.rs:1425-1427), so applications without the flag never added it. Claude was re-staged with it on 2026-10-11; Codex waits for a trust refresh (trusted_hash changes). Also: the HookArgs v2.6.3 range in the doc-contract test becomes :2961-2970, test 1 checks every --check-capture block, a new test fails on the previous text, and the read kit's "repositories commit the marker" comment is listed as a host note against .gitignore:73. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
section_from() used str.index, so a document lacking the #149 heading (the 16f0a1f text) gave 3 test errors instead of contract failures. It now raises AssertionError naming the heading, and the first #149 test no longer asserts on the whole document before extracting the section: the module gives 6 OK on the head text and 4 assertion failures, 0 errors, on the 16f0a1f text. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
…d pin it to the installed releases Fixes the four Codex review threads on #997 (each verified valid at 805aca0): 1. Contradiction. The two paragraphs after the correction said, in the present tense, that both clients' assistant Stop excerpts are opted in and that Codex trust ended in a captured outcome. They now open "At the 2026-09-21 qualification" (git blame 54896e7 and every artifact under evidence/artifacts/memory-landscape-20260921 carry that date) and point at correction #149. A new test reads that prose, which correction_149_section stops before. 2. Unverified host state. The 0 of 9 and 0 of 7 counts, the earlier hook applications, the Claude re-stage and the pending Codex trust are labelled CC host measurements, cited to correction #149 in command-center/lessons-20261005/cc-corrections-20261005.md and "not re-read by this change". 3. Pin. The host runs ai-memory 2.6.3 (385b81ea). install_hooks.rs:689-701, :1104-1109 and :1142 and render_shared.rs:1425-1427 are byte-identical at the same lines in v2.6.3 and v2.6.0 (89bd8ded), so both pins are cited and the test requires the v2.6.3 pin beside each cite. 4. Trust hash. Re-rendering changes the computed current hash; the stored trusted_hash is unchanged, the mismatch marks the hook modified, and the /hooks review writes the reviewed hash into trusted_hash (docs/decisions/2026-10-04-codex-rtk-hook-qualified.md Decision 1 at rust-v0.159.3; re-read at rust-v0.162.1 = 092d3acd, the installed codex-cli: discovery.rs:796-813 and :715-721, hooks_rpc.rs:58-92). The test rejects "re-rendering changes ... trusted_hash". tests/test_memory_landscape_capture_doc.py now has 10 tests: on the 805aca0 doc text the module gives 6 OK and 4 assertion failures, 0 errors (one per thread); on this text 10 OK. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
805aca0 to
8b8c8f5
Compare
…/lessons-20261005/... The #149 correction named the CC's ledger as command-center/lessons-20261005/cc-corrections-20261005.md, the form the brief prescribed. The CC recorded that as its correction #180: the ledger sits at coordination/lessons-20261005/cc-corrections-20261005.md (state-root relative), a sibling of command-center/, not under it. The doc keeps "(host state, not in this repository)"; the test now pins the true locator and rejects the old form. Found by looking up the file name under the host state root; the CC confirmed it in #180. Fail-before: with the new pin the module gives 9 OK and 1 assertion failure, 0 errors, on the 8b8c8f5 doc text; 10 OK after. validate.py and evidence_manifest.py --check pass. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 03fc660bcc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… to the native profile Fixes the two upheld Codex threads on #997 at 03fc660 (4245318057, 4245318059). The third, 4245318064 (P1, layer-resolution record), is not accepted: the layer-resolution protocol (#1008) governs layer adoption and verdict decisions, and this change adds no layer verdict. It corrects a host-state claim under AGENTS.md "Corrections", which the pinned sources already cited (ai-memory v2.6.3 = 385b81ea, Codex rust-v0.162.1 = 092d3acd) and the fail-before tests below satisfy. 1. The installer lead (4245318057). The retained 2026-09-21 record, evidence/artifacts/memory-landscape-20260921/native-commands.json:295-393 at 03fc660, shows the three installers run with --capture-assistant, exit 0 each, so the lead was true but undated; what it contradicted was correction #149's undated "The earlier hook applications ran without the flag". The lead now opens "At the 2026-09-21 qualification", cites that record and says it is not the hook state now. Correction #149 says the qualification's installers carried the flag, so the flag was lost before the 2026-10-11 measurement (the loss path is host history not reconstructed here), and names the two later flagless applications, the #144 repair and the 2.6.3 re-stage of 2026-10-10. "Not in force" is dated 2026-10-11. 2. The second Codex profile (4245318059). hook-trust.json at 03fc660 lists seven hook commands for the native profile (:35-77) and seven for the Desktop profile (:279-321), 14 in all, so the CC's 0 of 7 is one profile's. Correction #149 and the qualification prose after it now bound the count and the Codex conclusions (trust pending, capture off) to the native profile and say the Desktop profile was not measured. tests/test_memory_landscape_capture_doc.py has 16 tests (10 kept, 6 new). On the 03fc660 doc text the module gives 11 OK and 5 failures, 0 errors; on this text 16 OK. The new tests read the artifacts: the line ranges the doc cites, the flag and exit code of the three installer records, and seven commands per profile. manifests/evidence.json: hashes of the doc and the test re-registered only. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Scope
docs/memory-landscape-maintenance.md: the documented--capture-assistantopt-in was not in force on this host (0 of 9 Claude and 0 of 7 Codex hook commands carried it on 2026-10-11; the 0 of 7 is the native Codex profile's and the Desktop profile's seven were not measured; the counts, the Claude re-stage and the pending Codex trust are CC host measurements, recorded as correction Record the regular-session no-signal run and the first extended-hours paper run #149 incoordination/lessons-20261005/cc-corrections-20261005.md, not re-read by this lane). Claude was re-staged with it on 2026-10-11 and only its Stop hook carries the flag; native Codex is pending a trust refresh. Follow-ups from the docs: ai-memory allowlist capture was not in force on this host (correction #144) #988 read: the HookArgs v2.6.3 range in the doc-contract test is:2961-2970, test 1 checks every--check-capturesh block, and the read kit's "repositories commit the marker" comment is recorded as a host note against.gitignore:73(the kit lives in the co-op's host state directory, not this repository).8b8c8f54): the 2026-09-21 qualification prose after the correction is dated and points at correction Record the regular-session no-signal run and the first extended-hours paper run #149; the host state is labelled as CC measurements; the cites are pinned to ai-memory v2.6.3 = 385b81ea; the Codex trust-hash mechanism is corrected to the computed current hash versus the storedtrusted_hash.03fc660b, CC correction Document interim foundation/trading lane ownership (docs/lanes.md) #180): the ledger sits atcoordination/lessons-20261005/cc-corrections-20261005.md(state-root relative, host state), not undercommand-center/. The doc text and the test pin take the true form, and the test rejects the old one.07f373ec; the CC's adjudication of the three Codex threads on03fc660b): the installer lead atdocs/memory-landscape-maintenance.md:111-118is dated and cites the retained 2026-09-21 record (native-commands.json:295-393: the three installers ran with--capture-assistant, exit 0 each); correction Record the regular-session no-signal run and the first extended-hours paper run #149 no longer says "the earlier hook applications ran without the flag" (the same record contradicts it), names the two later flagless applications and dates "not in force" to 2026-10-11; its Codex count and Codex conclusions are bounded to the native profile (hook-trust.json: seven hook commands in each of two profiles, native:35-77, Desktop:279-321), and the Desktop profile is stated as not measured.3a8a8461ee60bd499efcb78156ce4c3c052430c5lane:foundationdocs/memory-landscape-maintenance.md,tests/test_memory_landscape_capture_doc.py,manifests/evidence.json(re-registered hashes only, in each of the five commits)Codex threads resolved
Each thread has a reply with the fix line and the commit. The first four are resolved at
8b8c8f54; the three Codex raised on03fc660bare resolved at07f373ec(two fixed, one not accepted).docs/memory-landscape-maintenance.md:136-145and:147-155) opens "At the 2026-09-21 qualification" and points at correction Record the regular-session no-signal run and the first extended-hours paper run #149;OlderQualificationStatementTestsreads it (correction_149_sectionstopped before it).03fc660bcorrects it.trusted_hashis unchanged, and the/hooksreview writes the reviewed hash; cited at Codex rust-v0.162.1 = 092d3acd and in the 2026-10-04 decision record.native-commands.json:295-393) shows they were, exit 0 each, so the lead was true but undated; the sentence it contradicted was correction Record the regular-session no-signal run and the first extended-hours paper run #149's undated "The earlier hook applications ran without the flag". The lead opens "At the 2026-09-21 qualification", cites the record and says it is not the hook state now (:111-118); Record the regular-session no-signal run and the first extended-hours paper run #149 (:134) says the qualification's installers carried the flag, the flag was lost before the 2026-10-11 measurement, the loss path is host history not reconstructed here, and two later applications (the Make verdict-review-gate apply the landscape validator's withheld-key policy #144 repair, the 2.6.3 re-stage of 2026-10-10) ran without it. The reading of the lead as a false claim is corrected by this artifact; the lead was not rewritten to say flagless. TwoInstallerLeadTeststests fail on03fc660b(the third guards the artifact and passes either way).hook-trust.jsonlists seven hook commands per profile, native:35-77and Desktop:279-321(14 in all), so the CC's 0 of 7 is one profile's. Record the regular-session no-signal run and the first extended-hours paper run #149 states the 0 of 7 as the native profile's, says the Desktop profile's seven were not measured (no claim about their flag or trust state) and bounds its Codex conclusions to the native profile; the qualification prose after the corrections (:153-155) does the same.CodexProfileScopeTests(2 tests) and oneOlderQualificationStatementTeststest fail on03fc660b.SOTA sources
385b81ea95f7b73ede7146d0ae606c4caa7b43c1(akitaonrails/ai-memory; the tag peels to this commit on the upstream remote andai-memory --versionon the host prints 2.6.3), read from the pinned local upstream mirror:crates/ai-memory-cli/src/commands/install_hooks.rs:689-701(an existing opt-in is preserved on a bare re-apply, never added),:1104-1109(existing_capture_assistant_opt_in) and:1142(baked_capture_assistantscans the installed ai-memory commands for the flag);crates/ai-memory-cli/src/commands/render_shared.rs:1425-1427(flag baked only whenevent == "stop");crates/ai-memory-cli/src/cli.rs:2961-2970(HookArgs, required--event,--agent,--server-url).89bd8ded3c1ab8b769cf99417d038ed0364403c8: the same install_hooks.rs and render_shared.rs ranges are byte-identical at the same lines (install_hooks.rs 660-705 and 1100-1150, render_shared.rs 1385-1432, diffed between the mirrors; the first differing hunks are install_hooks.rs:4316 and render_shared.rs:2179, plus same-count replacements at render_shared.rs:336 and :341);crates/ai-memory-cli/src/cli.rs:2957-2966(HookArgs).rust-v0.162.1=092d3acd6bec3e3a14bdc7e7a2810ab628ab759d(the tag peels to this commit on the upstream remote; the installedcodex-cliis 0.162.1), read from the pinned local upstream mirror:codex-rs/hooks/src/engine/discovery.rs:796-813(hook_trust_status: a stored hash that differs from the current hash isModified),:777-794(hook_hash) and:715-721(a hook runs only when Managed or Trusted unlessbypass_hook_trust);codex-rs/tui/src/hooks_rpc.rs:58-92(write_hook_trustswritestrusted_hash= the reviewed current hash). First-party:docs/decisions/2026-10-04-codex-rtk-hook-qualified.mdDecision 1 states the same mechanism at rust-v0.159.3.03fc660b(unchanged by this PR; the new tests re-derive every cited line range from the files):evidence/artifacts/memory-landscape-20260921/native-commands.json:295-393(hook-install-claude:295,hook-install-codex:328,hook-install-desktop:361, each with--capture-assistantin argv andexit_code0) andevidence/artifacts/memory-landscape-20260921/hook-trust.json:35-77and:279-321(seven hook commands for each of the native and Desktop profiles, the Stop commandmodifiedbefore the review andtrustedafter, in both).coordination/lessons-20261005/cc-corrections-20261005.md; that entry was read and matches the doc. The entry gives "0 of 7 Codex" without naming ahooks.json; the native scope is the CC's option in its adjudication, and the Desktop profile's flag and trust state stay unclaimed.Evidence-class table
source_reviewgit ls-remotesource_review8b8c8f54's locator, and pass after the editslocal_integrationsource_reviewsource_reviewnative-commands.json:295-393at03fc660b, read directly and re-checked bytest_the_cited_installer_record_carries_the_flag_and_exit_zerosource_reviewhook-trust.json:35-77and:279-321at03fc660b, counted byCodexProfileScopeTests03fc660b's text and pass on07f373eclocal_integrationLocal commands run
Decision record
None; a documentation correction with a regression test.
Host evidence
Not applicable (no
evidence/hosts/change).Follow-ups
hook-trust.json:279-321) were not measured on 2026-10-11, so their flag and trust state are unclaimed; measuring them, and re-staging with the trust refresh if they lack the flag, is a CC host action. Three notes are recorded here so they are not lost:--capture-assistanton 2026-09-21 (native-commands.json:295-393). The doc now says that, dates it, and no longer says the earlier hook applications ran without the flag; how the flag was lost by 2026-10-11 is host history not reconstructed here.8b8c8f54says every artifact underevidence/artifacts/memory-landscape-20260921/carries 2026-09-21. Precisely, four run artifacts carry 2026-09-21 timestamps (hook-trust.json,native-client-results.json,native-commands.json,state-observation.json),sources.jsoncarries it among older upstream dates, andqualification.jsoncarries no date. The doc claims only the date of the qualification prose.trusted_hashsentence, and the brief gave a locator that did not resolve. The CC recorded both as its correction Document interim foundation/trading lane ownership (docs/lanes.md) #180; this PR takes the true locator in03fc660band states the trust mechanism as the decision record does.Checklist
🤖 Generated with Claude Code
Follow-ups after landing (CC, 2026-10-12T08:53:46Z)
The final reads' P3s, carried here because the landing did not move the head:
07f373ec): the carried unittest diagnostic citation is still missing; keep ordinary Stop rendering distinct from recovery after manual config edits; inherited hostname labels; the cited captures are absent fromextra/; gaps in the merged-verification environment.07f373ec): the body says the tests "re-derive every cited line range", but correction Record the regular-session no-signal run and the first extended-hours paper run #149's repeat of295-393is a literal; "0 of 9 / 0 of 7 hook commands" counts ai-memory commands only (the live totals are 30 and 14); mutants M14 and M15 survive and M4 and M7 are carried; the kit quote is carried.