Repository navigation
Handle disappearing proc stat reads in Fleet cleanup regression - #946
Merged
seathatflowsinourveins merged 1 commit intoOct 9, 2026
Merged
Conversation
seathatflowsinourveins
marked this pull request as ready for review
October 9, 2026 23:07
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
seathatflowsinourveins
force-pushed
the
codex/ns2604-fleet-proc-race-20261009
branch
from
October 9, 2026 23:09
7720287 to
c414dc2
Compare
4 of 6 tasks
seathatflowsinourveins
deleted the
codex/ns2604-fleet-proc-race-20261009
branch
October 9, 2026 23:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Fix the Fleet producer cleanup test's
/proc/<pid>/statrace: when the descendant exits during the read,ProcessLookupErrororFileNotFoundErrornow means it is no longer active. A small helper reads once and retains the zombie (Z) check.3c01bdddc66896f8e36f9f21d452710808a9557e.lane:foundation.tests/test_local_pages_fleet_regressions.pyonly.7720287b09e498874756fadf3ee2e61021b44073.SOTA sources
errno.ESRCH; FileNotFoundError, corresponding toerrno.ENOENT. The installed Python is 3.13.16; CPython v3.13.16, Objects/exceptions.c contains both errno-to-exception registrations./proc/<pid>/stat, field (3) is process state andZis zombie.ESRCH.Evidence-class table
python3 scripts/validate.py: exit 0Local commands run
The fail-before run mechanically extracted main's exact
status.exists() and status.read_text().split()[2] != 'Z'expression without changing behavior, then mockedread_textraising each disappearance error. Both subtests failed on that expression before exception handling was added. The actual cleanup assertion now uses the same helper exercised by those regressions.The commit and native-shell push use repository hooks; no
--no-verifyis used. Tests ran normally, without a RAM gate, resource cap or nice wrapper. Hosted CI and the CC's Claude read remain separate acceptance gates.Decision record
This bounded test fix follows the CC's Fleet
/procrace slice. Handling disappearance at the read removes the existence/read race while retaining the existing zombie check. The helper catches onlyProcessLookupErrorandFileNotFoundError; other read failures still surface. No separate architecture decision is introduced.Host evidence
Not applicable: no host receipt or platform status changes.
Checklist