Repository navigation
Require upstream citations and failing regressions for corrections - #944
Merged
seathatflowsinourveins merged 4 commits intoOct 10, 2026
Merged
Conversation
seathatflowsinourveins
marked this pull request as ready for review
October 10, 2026 02:36
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
seathatflowsinourveins
deleted the
codex/ns2604-corrections-rule-20261009
branch
October 10, 2026 02:43
5 tasks done
seathatflowsinourveins
added a commit
that referenced
this pull request
Oct 12, 2026
…ith tests Unset workflow agents do not inherit the session model. The workflows page (Cost section) and the sub-agents page (Choose a model), read 2026-10-11 against Claude Code 2.1.296, resolve a workflow agent's model as a model the script names, then the definition, then CLAUDE_CODE_SUBAGENT_MODEL, then the session model, and adoption/templates/claude.settings.template.json:27 sets CLAUDE_CODE_SUBAGENT_MODEL to opus. The reason of the CLAUDE_CODE_WORKFLOW_SUBAGENT_MODEL row and the record's workflow-agent bullet now say so, and the dispositions catalog is re-registered in manifests/evidence.json. Only that row's reason text changed in the catalog; keys, dispositions, sources and versions are identical, and the watch's counts do not read the reason. The record said this repository's CLAUDE.md (8 lines) imports AGENTS.md (14 lines). AGENTS.md has 25 lines at 8c95a50 (#944 grew it before the rebase), and a count of a file other PRs edit goes stale in a record that is kept, so the record now states only the import. It also dated the first watch run "at the PR base", which every rebase moves; the row now names the original base, a7bb4a5 (main after #941, committed 53 s before the run), as the PR's body recorded it. Two tests in DispositionCitationTests guard these claims: - test_unset_workflow_agents_are_not_said_to_inherit_the_session_model - test_the_record_pins_no_instruction_file_line_count_and_no_relative_base (no line count after CLAUDE.md or AGENTS.md, no "the PR base", the run row names a commit, and CLAUDE.md still imports AGENTS.md through its @AGENTS.md line, which keeps the one relationship the record states true). On the tree of 37b9008 plus the test file, the two fail five sub-assertions (the row and the record say the agents inherit the session model, the row does not name CLAUDE_CODE_SUBAGENT_MODEL, the record pins "(8 lines)", and the record says "the PR base"); on this commit they pass. tests/test_upstream_surface_watch.py is re-registered in manifests/evidence.json. The record called #923 a draft; #923 landed in a30c218, its skill pins client_version 2.1.295 (reference/slots.json:3), and "Cloud routines" is a ranked alternative of the scheduled-tasks slot (reference/slots.json:1625). The record now says so, re-dates its exact-case search of the skill's pages, and adds the sub-agents and workflows pages read on 2026-10-11, with their body digests, to its SOTA sources. Its scope sentences and its evidence counts (233 tests with the two new ones) now name the regression tests. Not run: a probe of workflow-agent model precedence; the corrected sentences rest on the documentation, and the tests guard the committed text, not the client. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
seathatflowsinourveins
added a commit
that referenced
this pull request
Oct 12, 2026
…ith tests Unset workflow agents do not inherit the session model. The workflows page (Cost section) and the sub-agents page (Choose a model), read 2026-10-11 against Claude Code 2.1.296, resolve a workflow agent's model as a model the script names, then the definition, then CLAUDE_CODE_SUBAGENT_MODEL, then the session model, and adoption/templates/claude.settings.template.json:27 sets CLAUDE_CODE_SUBAGENT_MODEL to opus. The reason of the CLAUDE_CODE_WORKFLOW_SUBAGENT_MODEL row and the record's workflow-agent bullet now say so, and the dispositions catalog is re-registered in manifests/evidence.json. Only that row's reason text changed in the catalog; keys, dispositions, sources and versions are identical, and the watch's counts do not read the reason. The record said this repository's CLAUDE.md (8 lines) imports AGENTS.md (14 lines). AGENTS.md has 25 lines at 8c95a50 (#944 grew it before the rebase), and a count of a file other PRs edit goes stale in a record that is kept, so the record now states only the import. It also dated the first watch run "at the PR base", which every rebase moves; the row now names the original base, a7bb4a5 (main after #941, committed 53 s before the run), as the PR's body recorded it. Two tests in DispositionCitationTests guard these claims: - test_unset_workflow_agents_are_not_said_to_inherit_the_session_model - test_the_record_pins_no_instruction_file_line_count_and_no_relative_base (no line count after CLAUDE.md or AGENTS.md, no "the PR base", the run row names a commit, and CLAUDE.md still imports AGENTS.md through its @AGENTS.md line, which keeps the one relationship the record states true). On the tree of 37b9008 plus the test file, the two fail five sub-assertions (the row and the record say the agents inherit the session model, the row does not name CLAUDE_CODE_SUBAGENT_MODEL, the record pins "(8 lines)", and the record says "the PR base"); on this commit they pass. tests/test_upstream_surface_watch.py is re-registered in manifests/evidence.json. The record called #923 a draft; #923 landed in a30c218, its skill pins client_version 2.1.295 (reference/slots.json:3), and "Cloud routines" is a ranked alternative of the scheduled-tasks slot (reference/slots.json:1625). The record now says so, re-dates its exact-case search of the skill's pages, and adds the sub-agents and workflows pages read on 2026-10-11, with their body digests, to its SOTA sources. Its scope sentences and its evidence counts (233 tests with the two new ones) now name the regression tests. Not run: a probe of workflow-agent model precedence; the corrected sentences rest on the documentation, and the tests guard the committed text, not the client. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
seathatflowsinourveins
added a commit
that referenced
this pull request
Oct 12, 2026
… rust-v0.162.1 (#950) * Resolve the upstream-surface backlog to Claude Code 2.1.296 and Codex rust-v0.162.1 Disposition the 49 open names plus two the docs do not list yet, re-review the Claude memory and skills document rows, advance the baseline from 2.1.289 and rust-v0.160.0, and record the gaps, the page-digest rows not added and the hand-offs in one decision record. Data only: no code, instruction text, setting, hook or unit changes. Co-Authored-By: Claude Sonnet 5.5 <[email protected]> * Record the command center's rulings on the four open upstream-surface rows Leave CLAUDE_CODE_WORKFLOW_SUBAGENT_MODEL unset (declined); decline ultrafast_mode (plan-gated, dropped client-side by the OmniRoute profile); keep the Codex cyber access programs as owner information only; decline the model_providers capabilities rows until the currency lane's trial after #943. Rows, decision record and the re-registered catalog hash change together. Co-Authored-By: Claude Sonnet 5.5 <[email protected]> * Name an owner for each follow-up and hand-off in the gap-resolution record The page-URL diffs go to the command center (through the daily watch service it installs after #943), the changelog-name report to the currency lane, and the settings-drift inventory to cc-native-practice. The weekly practice pass, the TeammateIdle gate, the cost-data check and the WebSearch interaction now say who acts or that nothing is scheduled. Co-Authored-By: Claude Sonnet 5.5 <[email protected]> * Correct four claims in the gap-resolution record; guard two of them with tests Unset workflow agents do not inherit the session model. The workflows page (Cost section) and the sub-agents page (Choose a model), read 2026-10-11 against Claude Code 2.1.296, resolve a workflow agent's model as a model the script names, then the definition, then CLAUDE_CODE_SUBAGENT_MODEL, then the session model, and adoption/templates/claude.settings.template.json:27 sets CLAUDE_CODE_SUBAGENT_MODEL to opus. The reason of the CLAUDE_CODE_WORKFLOW_SUBAGENT_MODEL row and the record's workflow-agent bullet now say so, and the dispositions catalog is re-registered in manifests/evidence.json. Only that row's reason text changed in the catalog; keys, dispositions, sources and versions are identical, and the watch's counts do not read the reason. The record said this repository's CLAUDE.md (8 lines) imports AGENTS.md (14 lines). AGENTS.md has 25 lines at 8c95a50 (#944 grew it before the rebase), and a count of a file other PRs edit goes stale in a record that is kept, so the record now states only the import. It also dated the first watch run "at the PR base", which every rebase moves; the row now names the original base, a7bb4a5 (main after #941, committed 53 s before the run), as the PR's body recorded it. Two tests in DispositionCitationTests guard these claims: - test_unset_workflow_agents_are_not_said_to_inherit_the_session_model - test_the_record_pins_no_instruction_file_line_count_and_no_relative_base (no line count after CLAUDE.md or AGENTS.md, no "the PR base", the run row names a commit, and CLAUDE.md still imports AGENTS.md through its @AGENTS.md line, which keeps the one relationship the record states true). On the tree of 37b9008 plus the test file, the two fail five sub-assertions (the row and the record say the agents inherit the session model, the row does not name CLAUDE_CODE_SUBAGENT_MODEL, the record pins "(8 lines)", and the record says "the PR base"); on this commit they pass. tests/test_upstream_surface_watch.py is re-registered in manifests/evidence.json. The record called #923 a draft; #923 landed in a30c218, its skill pins client_version 2.1.295 (reference/slots.json:3), and "Cloud routines" is a ranked alternative of the scheduled-tasks slot (reference/slots.json:1625). The record now says so, re-dates its exact-case search of the skill's pages, and adds the sub-agents and workflows pages read on 2026-10-11, with their body digests, to its SOTA sources. Its scope sentences and its evidence counts (233 tests with the two new ones) now name the regression tests. Not run: a probe of workflow-agent model precedence; the corrected sentences rest on the documentation, and the tests guard the committed text, not the client. Co-Authored-By: Claude Sonnet 5.5 <[email protected]> --------- Co-authored-by: Claude Sonnet 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
New WSL configurations and scaffolded repositories previously rendered the old correction rule while root AGENTS carried the amendment. All six philosophy layers now require the same amended core: resolve a wrong claim or fix from the pinned upstream primary source through the vendor's supported path, record the cited correction, add a regression test that fails before the fix, and measure first-hand when sources disagree. The native Claude, Codex and scaffold producers emit the new sentence once and omit the old sentence.
Restoring that sentence also changes the Codex template's live top-segment digest. The worker-lane test still expected the preceding core's digest and failed against the corrected carrier. This follow-up calculates the digest with the existing
template_segments()helper and updates its live constant and two explanatory comments. The hash assertion and all four RTK constants remain byte-identical; historical digest records remain unchanged.3c01bdddc66896f8e36f9f21d452710808a9557e.lane:shared.9d101e6cc842bea3b01842bc6087bc219d946034.fad389cc710eca096fef037c2600d488428a85fb; no rebase.b7bd72038ef0482700466a8d8fc06b93a19815ca.The three common sources are
examples/claude-native/CLAUDE.md,adoption/templates/codex.AGENTS.template.mdandadoption/scaffold/AGENTS.md. The existing native--write-blockspath regeneratesadoption/new-wsl/claude-user-instructions.mdandadoption/new-wsl/codex-user-instructions.md. Each carrier's preceding fix changed only the exact sentence, +225 bytes; inverse projections restore7cf7a7f9bytes exactly. This follow-up changes none of those carriers.The root/trading policy and directly delivered Corrections review group retain their verified placement. Updating versioned repository inputs and generated carriers is distinct from applying actual user-level files, which remains the CC's separate post-landing stage. The existing scaffold whitespace-drift regression follows the amended sentence's ending; its native detector remains unchanged.
SOTA sources
2026-10-09and rechecked by the co-op at about23:01Z: documents## Code Review Rules, optional###groups, and root/nested AGENTS guidance scoped to changed files.6c42c8ab1e287a160da43b48b75692b42b880a81, AGENTS.md:139–143: exact Corrections group and safe path. This reference is an open PR at the observed pin, not a merged acceptance result. The root and REVIEW groups remain byte-identical to it: 275 bytes, SHA256a1c6e526b4f478ffc1e5fce5e9b5ecf521aa7f321df7a66876a010f54e167747.native-agent-stack@7cf7a7f9fa75a75e15f3b08bab3ecce3b9edaa0f: new-WSL block producer, its--write-blocksbranch at lines 2752–2771, and scaffold producer. These existing producers remain unchanged.fad389cc710eca096fef037c2600d488428a85fb, tests/test_codex_worker_lane.py:422:template_segments()measures the rendered top separately from upstream RTK awareness. The live digest now equals its native return value, 1,917 UTF-8 bytes and SHA256ae8f16bedb8cabc753114c4b8fbce3ef8e835ac50ea36aefb870671bf1ae8023; the hash assertion is preserved.tests/test_install_claude_profile.py,tests/test_scaffold_repo.py,scripts/host_receipts.pyandscripts/validate.py. Native registration and validation remain the supported path; no new renderer, package, client integration or digest helper is introduced.Evidence-class table
source_review/local_integration7cf7a7f9,GPT-VERDICT-7cf7a7f9f.md, SHA256237eb87d6a9b4a85512be9a35d0bb781569f627866fc2a2543b27580e7ff49cb. Repository-carrier deferral was corrected atfad389cc; actual user-level application remains separate.local_integration— prior composition2026-10-09T23:07:49Zbefore source update at23:08:35Z. All three actual producers returned old=1/new=0. Focused GREEN: 20 tests, 0 skips, completed23:10:48Z; native outputs have old=0/new=1/common-core=1. Independent pure-output audit at23:11:42Zconfirmed matching carrier hashes. These results belong to the carrier fix, not a new broad rerun at the latest head.local_integration— prior composition2026-10-09T23:10:55Z: exact sentence-only +225-byte projection on each carrier; inverse restores7cf7a7f9. Root/trading/REVIEW/CLAUDE stayed accepted-parent byte-identical. Native regeneration exited 0 with no omitted units.local_integration— prior composition2026-10-09T23:16:54Z, then the three-module run passed.local_integration— prior composition1272782fff4c4246f26ba6624d17a43f99de48cc/ commitfad389cc: normal run exit 0, 365 tests,OK (skipped=1),2026-10-09T23:19:13Z–23:21:04Z, 110.74 seconds. Output SHA256d2f326d8726a273fbb07dd95e063c66fad2a68509b15a1299179418f35143d3b. These modules were not broadly rerun for the constant-only follow-up.local_integrationNAS_CODEX_INTEGRATIONunset: exit 1, one test/one failure, completed2026-10-10T00:11:49Zagainst the preceding live constant.local_integrationtemplate_segments()gives 1,917 bytes / SHA256ae8f16bedb8cabc753114c4b8fbce3ef8e835ac50ea36aefb870671bf1ae8023. Targeted GREEN: exit 0, one test, completed2026-10-10T00:13:11Z. Source comparison preserves the entire hash assertion and all four RTK constants byte-for-byte; assertion-method SHA2567a24ba7cc8ae3f33c076c6e2561f7c18116a96b05bbb5515ae5289364529ee1d. Only the top constant and two comments change; three old-digest historical occurrences stay unchanged.local_integrationNAS_CODEX_INTEGRATIONunset: exit 0, 123 tests,OK (skipped=12),2026-10-10T00:13:38Z–00:14:45Z. Real app-server integration remains opt-in and was not run.local_integration2026-10-10T00:16:37Z; 11,286 rows, no membership/order change. Manifest SHA2561f1daa174fa6cfeb217b3fef2b2c0691c292404ca5433760a0796afe83afd99c. Earlier carrier registration updated seven existing payload rows and added the scaffold-test row.local_integrationpython3 -B scripts/validate.py: exit 0,2026-10-10T00:16:48Z–00:17:38Z, 49.61 seconds; 11,286 hashes, 70 components, 4 profiles, 239 receipts. Output SHA2560f75e77db94262f206a41d8a912103a191e5f9ab8369ad954c983b7d29e000be. Exact validated treeb7bd72038ef0482700466a8d8fc06b93a19815cacommitted at00:18:11Z.local_integration9d101e6c, MERGE_HEAD is immutable maina7bb4a51eea9cc321dd06dd6243a5b2654a5f805; actual merge-base3c01bdddc66896f8e36f9f21d452710808a9557e. Native merge completed without conflicts and auto-merged the manifest, producing staged treeb22adf5b8e2f42262fc10bafcbef136457202a23at2026-10-10T00:19:17Z. This is an uncommitted merge composition, not a source-branch merge or rebase. Its normal full worker-lane run exited 0: 123 tests, 0 failures/errors, 12 skips,00:19:55Z–00:21:06Z, 70.81 seconds; output SHA256aaedb81495c72c31242ee819c51231d0558bf93bd5ef08e2f6d044c4936e82db.local_integrationpython3 -B scripts/validate.pyon staged treeb22adf5b8e2f42262fc10bafcbef136457202a23: exit 0,2026-10-10T00:21:22Z–00:22:15Z, 53.3 seconds; 11,297 hashes, 70 components, 4 profiles, 239 receipts. Output SHA256534bf2b7c733b70588b934a6ab122cb86c1c325948a3d6b4ec216721b0b332be. Postchecks at00:22:41Zretain that staged tree and fixed HEAD/main MERGE_HEAD, with no unmerged paths, no unstaged tracked diff and no cached diff-check errors. The manifest auto-merged cleanly; no regeneration was needed. This composition remains uncommitted. Its 11,297 hashes are distinct from the source tree's 11,286.local_integration— prior composition, unchanged by this fixLocal commands run
The preceding carrier correction's exact commands and receipts remain in the dated decision and prior PR-body receipt. Its full installer/scaffold/new-WSL result is scoped to
fad389ccabove. The latest follow-up runs are:This description is prepared before publication. Publication uses the tracked native pre-push hook and a normal follow-up push; its exit code, exact remote head and readback remain in the external lane receipt so preparation does not disturb the new-head CI run.
Decision record
docs/decisions/2026-10-09-corrections-rule.mdat final head9d101e6crecords the correction requirement, immutable reference group, vendor review mechanisms, six-layer invariant, native producers, fail-before reproduction, measured byte cost and live-pin correction. Historical consolidation measurements and sealed proposal digests retain their dated meaning.The record retains fixed startup ceilings and requires designated reviews to assess the +922-byte growth. Revisit placement if official guidance changes, a hosted review exposes a delivery gap, or measured context cost is unjustified. Local green tests and source reads do not establish hosted bot enforcement.
Host evidence
This PR changes repository instruction sources, committed generated carriers and their guards. It introduces no host receipt or platform-status change and applies no actual user-level file. Client configuration, credential contents and private-name patterns are not read or changed. Existing custom Claude Actions prompts remain a separate integration. Worker-lane integration cases remain disabled for these local gates.
Checklist
lane:sharedPR by comment or review underdocs/lanes.md:145–150.