Repository navigation
Allow configured loopback Loki endpoints for native-data - #919
Draft
seathatflowsinourveins wants to merge 2 commits into
Draft
seathatflowsinourveins wants to merge 2 commits into
seathatflowsinourveins wants to merge 2 commits into
Conversation
5 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
NativeStack2604 uses Loki on port 21300, but native-data's config validation required the authoring host's port 13100. Accept the configured
loki_urlfor HTTP IPv4 loopback literals (127/8) or IPv6 ::1, an explicit valid port and the exact/loki/api/v1/pushpath. The existing publisher already sends toconfig["loki_url"]; removing the fixed endpoint restriction makes that configuration usable.52ed48881115adb072385456060a80e70e57e3d8.lane:shared, because the required evidence hash registrations touch the shared manifest. Other-lane acknowledgement remains required before merge.observability/native-data/snapshot.py,observability/native-data/README.md,tests/test_native_dashboard_data.py, and only those three entries inmanifests/evidence.json.SOTA sources
52ed48881115adb072385456060a80e70e57e3d8; this change uses the installed standard library and the existing adapter without adding a dependency or replacing a native runtime.Evidence-class table
test_publish_posts_to_the_configured_loopback_endpoint: a local HTTP listener, synthetic collection rows, actual existing HTTP transport and main entrypoint; HTTP 204tests.test_native_dashboard_datatests.test_native_dashboard_data, rc 0scripts/validate.py, rc 0; 10921 hashed files checkedLocal commands run
Decision record
The NativeStack2604 section in
observability/native-data/README.mdrecords the configurable endpoint, private-config and published timer requirements, report-source dependency and post-application acceptance. The dated 2026-10-09 source/proposal record accompanies the CC packet. A strict regex on the original string plus the maintained IP parser was selected over parser-only URL validation because the parser normalizes controls. A change in upstream IP/URL semantics would require rerunning the boundary tests and reviewing the guard.Placeholder-only private-config and user-timer diffs, each with an inverse, are retained in the CC coordination packet with SHA-256 custody. The CC must render and apply them privately with config mode 0600 and state mode 0700. Context Mode for both clients, Headroom and jCodeMunch come from an existing current
token_reportand matching scope labels; this collector does not refresh that producer. No private configuration or systemd unit is installed by this PR or this lane.Host acceptance remains pending CC application: a positive Loki
count_over_time({service_name="agent-stack-native-data"}[30m]), then native-foundation-data screenshot, zero console errors/failed network requests and the current generation across savings, memory and coverage panels. Buildinfo and local fixture HTTP tests do not establish host ingestion.Host evidence
No files under
evidence/hosts/or platform status fields change. No native-proven ingestion claim is made.Checklist