Repository navigation
Record blinded skills validator trials and stale source rule - #918
Conversation
0a41c4f to
6facffa
Compare
6facffa to
0c21ff1
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0c21ff1acf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| prereg = Path(__file__).resolve().with_name("PREREGISTRATION.md") | ||
| if digest(prereg) != PREREG_SHA: | ||
| parser.error("preregistration differs from frozen bytes") | ||
| corpus = args.corpus.resolve() | ||
| case_file = corpus / "cases.json" |
There was a problem hiding this comment.
Enforce the locked corpus hash before execution
When any fixture or reference changes after the preregistration is locked, this runner still proceeds because it verifies only PREREGISTRATION.md and merely records the cases.json digest; it never compares the full corpus against preregistration-lock.json's corpus_sha256. A replay can therefore score non-frozen inputs while presenting them as the preregistered trial, so compute the documented directory hash and fail before execution on a mismatch.
AGENTS.md reference: AGENTS.md:L7-L7
Useful? React with 👍 / 👎.
| write_json(out / "native-results.json", {"preregistration_sha256": PREREG_SHA, | ||
| "cases_sha256": digest(case_file), "tool_files": { | ||
| name: {"path": str(p), "sha256": digest(p)} for name, p in tools.items()}, | ||
| "python": sys.version, "records": results}) | ||
| write_json(out / "finding-views.json", {"requires_parent_anonymization": True, "records": views}) |
There was a problem hiding this comment.
Emit the retained native-results schema from the runner
Every execution of this code writes native-results.json without artifact_hash_domain, although the committed artifact begins with that field and publication-redaction.json says the file changed only through home-prefix redaction. Consequently the retained artifact cannot be reproduced by the committed controller and contains an undisclosed metadata edit; either emit the field here or explicitly record the post-processing transformation.
AGENTS.md reference: AGENTS.md:L7-L7
Useful? React with 👍 / 👎.
| }, | ||
| "method_limits": [ | ||
| "One synthetic corpus, one fresh host/model session and one independent judge; no confidence interval or general ranking", | ||
| "NVIDIA quality template warnings and duplicate native structured/legacy findings were retained. The preregistered assertion-count F1 penalizes these; it does not establish its semantic quality, safety or Tier2/Tier3 performance", |
There was a problem hiding this comment.
Stop calling the duplicate-entry penalty preregistered
The preregistration defines false positives as unsupported assertions, but it never freezes a rule that separately emitted structured and legacy copies count multiple times; that per-finding-entry rule first appears in the sealed judge's post-outcome metric_notes. Arm-2 is then penalized for duplicated schema/legacy representations, so describing this as the “preregistered assertion-count F1” overstates the protocol and makes the reported comparison depend on a post-outcome scoring choice; mark it as an unpreregistered sensitivity analysis or rescore unique semantic assertions.
AGENTS.md reference: AGENTS.md:L7-L7
Useful? React with 👍 / 👎.
| The fresh `tests.test_landscape_sweep_skills` run at the final rebased head, | ||
| validator result and designated pre-cue result are retained with their exact | ||
| commands, head and log hashes in the separate rebase publication receipt: | ||
| `<host-home>/.local/state/native-agent-stack/research/api-surfaces-trials/skills-trials-20261009/rebase-918-20261009T0911Z/rebase-publication.json`. |
There was a problem hiding this comment.
Commit the claimed exact-head validation receipt
The only in-tree landscape-test log is explicitly declared not to validate the rebased head, while the replacement evidence is referenced solely through a <host-home>/.local/state/... path outside the repository. A reviewer, CI job, or later checkout therefore cannot inspect the exact commands, tested head, or log hashes supporting the claimed final-head validation; commit a sanitized receipt and its bound logs or stop describing them as retained evidence.
AGENTS.md reference: AGENTS.md:L7-L7
Useful? React with 👍 / 👎.
Scope
Records one preregistered, blinded instructions/skills validation trial, isolated vendor install/check/inverse stages, and a default-branch maintenance recheck. agnix remains a trial, SkillEvaluator remains keep-but-compare, and openai/skills is stale-not-maintenance-qualified; neither candidate is ADOPT-NOW.
958a6d1ab770c807c5ee59748475a5c14df7ba52.6facffaa82f70782835eb7b3343739d13f02d523.lane:foundation.evidence/artifacts/skills-trials-20261009/,docs/decisions/2026-10-09-skills-blinded-trials.md, andmanifests/evidence.json.checks/landscape-skills-tests.logis explicitly labelled pre-restoration inchecks/README.md. The fresh module run below validates the final rebased head.SOTA sources
website/docs/installation.md, nativetests/eval.yaml,.github/workflows/ci.yml,crates/agnix-cli/src/json.rs, andskills/agnix/SKILL.md. Vendor archive and installed binary hashes are retained.register_fileregenerates registrations from actual file bytes; its supported invocation is documented intools/sota-convergence/landscape-sweep/README.md:640–646. Regeneration preserves all 10,939 main registrations and the original 225 lane registrations, with one additional provenance README.Evidence-class table
PREREGISTRATION.md,preregistration-lock.json,judge-execution.json, redacted events and blinding auditRESULT.jsoninstall-and-inverse.jsonand vendor/upstream test logsfresh-session.json; original events privately retained with redaction mappingsha=main&since=2026-07-11T05:20:15Z&per_page=1REST result inopenai-maintenance.jsonLocal commands run
Pinned vendor outcomes remain retained: agnix native eval 61/61 cases; NVIDIA targeted schema, quality and CLI modules 51, 144 and 20 passed respectively; skills-manifest module 33 passed. These outcomes were not rerun during the rebase.
At
6facffaa82f70782835eb7b3343739d13f02d523:Fresh logs and exact commands are retained in
<host-home>/.local/state/native-agent-stack/research/api-surfaces-trials/skills-trials-20261009/rebase-918-20261009T0911Z/rebase-publication.json. Independent bounded audit verified the manifest union, retained trial bytes, historical log and frozen catalog/test identity.Decision record
docs/decisions/2026-10-09-skills-blinded-trials.md. This small synthetic diagnostic does not establish semantic quality, safety, live-evaluation superiority or a whole-repository replacement. agnix's separate instruction clean-control gate fails. Its routing-proof status is exactlyunavailable: skill install is CC-gated; the historical unnamed-session observation remains separately retained. The CC must apply a reviewedadoption/skills/manifest.jsonrow throughtools/adoption/install_skills.pybefore owning the later routing proof. Per-session memory qualification is unmeasured and ADOPT-NOW remains false. Existing pinned skills remain while the general comparison is unresolved; catalog disposition follows its designated route.Host evidence
No
evidence/hosts/receipt or platform-status change is included. Fresh exact-head review, hosted required CI and the CC/5f cue continue to gate landing; live skill/hook/client configuration remains owner-gated.Checklist