Repository navigation
Record role tool sets and MCP memory gates - #910
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Role sets now cover their observed necessary servers with client-specific selection. Exec readers require EVALUATION, the narrowest existing contract covering all nine observed servers; conflicts with live lane exclusions go to the CC and intentional exclusions require a deciding file and decision. The record separates historical trial sets from live settings and aligns every named catalog disposition with its actual verdict row.
72e1f943d951e6aff4200729db88121a8d38d7da.897b87229c2d59f93244ae6e4b9038de4a739469.779fa242b4b3dd9c25f53295de49b3d0e5b2ab7d; one additional repair commit and one push, no rebase.lane:foundation.docs/role-tool-sets.md,docs/role-tool-sets.json,docs/convergence-architecture.md,adoption/README.md, and documentation metadata inmanifests/evidence.json. The final FIX2 delta updates only the two role records; earlier architecture/adoption links and manifest integrity remain part of the five-file PR.The live Codex exclusions are bound per named lane to role-mcp-off.json v2 SHA256
77c91cdc0433f54ecacb070a4581ec7f20443d9d5835e7fb938f3994e6563107. CORE is explicitly the historical trial base; all four trial arms usedrole_mcp_off=skip. Claude's twelve-component strict selection contract needs grafana and agentsview additions for the CC/co-op; all observed necessary servers remain covered by role-specific contracts. Unknown coverage cannot pass a server reduction or shared-MCP topology decision.Stage 1 uses valid array-index catalog verdict pointers: Context Mode and jCodeMunch are measured trade-offs, Headroom and GitHub CLI candidate:cli-cli are winners for their respective jobs, CBM and agentsview are conditional, and Hindsight is unqualified. Semble/browser links are layer context only. The coordination composition is pending and owned by orch-records. Hcom's tree and installed pins are distinguished, and grafana-observation pins the MCP connector. The architecture paragraph is appended to restore the test-enforced citation at line 134. Optional QMD cohort numbers are omitted because original observer files are not bound to this numerical packet. Each historical arm separately cites a hashed release.out:2 record for role_mcp_off=skip. The agentsview table is contiguous, api-actions has review-specific acceptance, and the Claude schema source identifies the 1000-byte span, start and term offsets. The profile readback came from the identity-launcher binary reporting Codex 0.161.0; launch metadata and native execution stay separately scoped.
SOTA sources
98c935556619bbd70ec55ddd7b923bb1b8ff797de883af82e9af1401f47e1cc9. Native child MCP scopes remain separate from independent-process selection.Evidence-class table
f0afc2c734b3ad1b70e68cd38d3c844c7f4b1338cc030c8fc40fc88db1e53989; after-task hashes and trial skip setting in JSONe129759fe91ffbb133de2719a7d5194fe96ac65c44b222adf7fdd4d65af0e872; original plugin names preservedEach test module ran under nice/ionice with timeout 600. Counts above exclude skips from passed totals. Complete returned stdout/stderr and return codes are retained in the private verification record. These are existing repository checks, not vendor acceptance.
Per-tool PSS, fresh concurrent sharing, effective Claude registration readback, generic role/phase mappings and role 99's native client remain unmeasured. No runtime configuration, model route, provider trial or deployment changed. FIX2 incorporates the CC micro's 2 P2/7 P3 and the designated GPT micro's same table P3. The read-only completeness critic reports PASS WITH BOUNDARIES. Both designated exact-head reads, CI, required pre-cue tooling, the CC cue and owner decisions remain required for landing.