Repository navigation
Test guard-only failure blocking in new-WSL render - #908
Merged
seathatflowsinourveins merged 1 commit intoOct 9, 2026
Merged
Conversation
seathatflowsinourveins
force-pushed
the
codex/ns2604-guard-render-test-20261009
branch
from
October 9, 2026 01:47
f5435d9 to
ff56fe2
Compare
seathatflowsinourveins
marked this pull request as ready for review
October 9, 2026 02:32
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
seathatflowsinourveins
deleted the
codex/ns2604-guard-render-test-20261009
branch
October 9, 2026 02:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Add a regression test against the actual new-WSL rendered
settings.json: exactly onesecret_path_guard.pycommand hook must be underPreToolUsewith matcherBashandonFailure == "block". Every other hook must omitonFailureentirely.This draft targets
mainand contains one test commit above the landed guard change. Required designated GPT and CC reads, J8 for test code, CI and the pre-cue check remain landing gates; landing requires the command center's cue through 5f.2489b8481042755586a2d2005125d5359627f6c4.lane:foundation.tests/test_new_wsl_client_config.py; its existing hash/byte row inmanifests/evidence.json, refreshed on main's manifest throughscripts.host_receipts.register_file.SOTA sources
onFailure: "block"for command and HTTP hooks. The pinned upstream release note was fetched independently for this follow-up.Evidence-class table
local_integrationtests.test_new_wsl_client_configrerun after the rebase: rc 0, 229 tests, OKblockor another valuesyntheticlocal_integrationscripts/validate.py: rc 0;scripts/evidence_manifest.py --check: rc 0source_reviewThese checks cover rendered configuration. Live Claude Code execution behavior remains the parent PR's separately recorded evidence.
Local commands run
The check process ran under
nice -n 10 ionice -c2 -n7; the commands below were run after the rebase.Decision record
The parent decision,
docs/decisions/2026-10-08-guard-hook-fails-closed.md, documents the field and the render regression gap. This test closes that gap using the existing renderer fixture. Exact rendering regressions would fail the assertion; an independently supported change to the guard declaration would require reviewing the expectation.Host evidence
No files under
evidence/hosts/are changed. Required designated reads, J8 for test code, CI and the pre-cue check remain landing gates.Checklist
permissions: {}and grant each job only what it needs. No workflow change.