Repository navigation
Register Hindsight research memory and service templates - #854
seathatflowsinourveins merged 2 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fe805df48b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
e1e28fe to
22ec893
Compare
|
Dependency limit exceeded — report not shown. This pull request scan exceeded the 10,000-dependency limit applied to this scan, so the results are incomplete and may be inaccurate. To avoid reporting false positives, Socket has not posted a report. Upgrade your plan to raise the dependency limit and get complete reports, or view the partial scan in the dashboard. Socket is always free for open source. If this is a non-commercial open source project, contact us to request a free Team account. |
22ec893 to
2f6c0f0
Compare
### Scope Codex cloud review remains in use, but the landing procedure has no per-thread disposition step. This adds that step to the existing **Landing** section: read every connector thread and comment, retain a fixed/replied/not-applicable disposition and evidence, and re-read the exact head and all conversations before declaring readiness. - Base commit: `64a8cda01700d5e823c18e4b989e856de2ee2241` - Lane: `lane:foundation` - Owned paths: `docs/command-center.md`; its evidence hash is refreshed in the last registry-only commit. ### SOTA sources - [Official OpenAI Codex GitHub review](https://developers.openai.com/codex/integrations/github), fetched 2026-10-08: supported cloud review remains the native route. - [cli/cli v2.102.0](https://github.com/cli/cli/releases/tag/v2.102.0), installed native client, and [gh api manual](https://cli.github.com/manual/gh_api): GraphQL pagination requires an end cursor and pageInfo for the connection being paged. - [GitHub GraphQL pagination](https://docs.github.com/en/graphql/guides/using-pagination-in-the-graphql-api) and [native conversation resolution](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/commenting-on-a-pull-request#resolving-conversations), fetched/reviewed 2026-10-08. Live native schema and thread returns distinguish outdated, resolved, author and original-commit state. ### Evidence-class table | Claim | Evidence class | Command / receipt | | --- | --- | --- | | Native thread metadata supports the documented read | native_proven within the RPC scope | Read-only paginated `gh api graphql` on PR #854: 4 connector threads, all outer/nested comment pages complete, 0 unresolved; no reply/resolution mutation | | Every disposition is bound to evidence and the landing head | source_review | Existing Landing subsection plus independent completeness critic; no workflow/bot/ruleset code | | The document and registered hash are consistent | local_integration | `python3 scripts/validate.py` and `git diff --check`, both exit 0 | ### Local commands run ```text gh --version gh version 2.102.0 gh api graphql --paginate --slurp -f query=<retained query> exit 0: PR #854 returned 4 connector review threads; all pageInfo.hasNextPage fields false python3 scripts/validate.py exit 0: repository integrity/scope passed git diff --check exit 0 ``` The full native query/output is retained privately with its actual post-exec argv. A CLI option-validation failure before the request was retained and corrected; it is not a provider failure. Metadata reads do not prove semantic triage or future enforcement. No low-impact document test was added. **Modified test files:** none. **Declared modified-test failing set:** empty. ### Decision record The new `docs/command-center.md#codex-cloud-review-thread-triage` subsection is the source-reviewed B3 procedure. It explicitly covers resolved/outdated threads and nested comments, both connector login spellings, current-head evidence, justified resolution, zero-thread proof and invalidation after a push, thread or comment. A reply, outdated flag or green CI cannot justify resolving a valid outstanding finding. PR #859 was independently confirmed MERGED first at `64a8cda01700d5e823c18e4b989e856de2ee2241`; its landed map blob matches the retained SHA256. The inverse for B3 is to revert the documentation and its final registry hash coherently. ### Host evidence No host installation, platform status, client configuration or credential change. ### Checklist - [x] No workflow, ruleset, frozen input or always-loaded instruction surface changed. - [x] No credential value or private host state is published. - [x] No paid service or billing surface introduced. - [x] Peer-owned worktrees and private landing code preserved. - [x] Evidence registry is the final commit. - [x] Landing remains with 5f under the standing cue when required-green and zero threads.
Scope
Registers Hindsight 0.10.2 as supporting research memory and publishes its native user-service/MCP templates. Startup orders after OmniRoute and retries failures; a later nonsecret environment file keeps the 15-tool allowlist authoritative. Verbatim research recall selects
types: ["world", "experience"].Completes selected-component freshness coverage and refreshes the handbook through its existing generator. The Hindsight insertion also moves one architecture citation; its model revision is unchanged. Main's component rows, prior snapshot observations and historical receipt entries are preserved.
lane:foundation, under the command center's foundation publication assignment.eb5fee4db9a494729deb29bdf38dbabac23ee643; one landing rebase.SOTA sources
Validation and evidence
scripts/validate.py, landscape, explorer and handbook checks; source/history completeness reviewActions run 37786314228 failed five tests and one fixture setup because selected Hindsight freshness coverage and generated source hashes were incomplete. Native red loops reproduced those failures. The repair uses the repository's snapshot convention, unchanged generators and existing tests. All five failed shard module groups were also executed locally; their additional container-environment failures are retained separately with subsequent native module rechecks. Counts overlap and are not summed. No test assertion, skip or gate was weakened.
Additive
ci-repair.jsonpreserves that failed run, first local shard reports, corrections, successful module results, output hashes and environment limits. The original Hindsight artifacts stay byte-identical. The handbook receipt's current producer/output bindings are refreshed while every previous binding and observation remains recorded.The local Docker environment does not reproduce the Azure VM/kernel or every preinstalled hosted tool. Hosted new-head CI remains the acceptance gate; local manifest validation alone is not a passing hosted run. Exact post-hook outer commands and original outputs are retained privately; public commands and hashes preserve their sanitized scope.
Host evidence
No platform-status flip or host-evidence entry. This PR changes repository templates and evidence; the live Hindsight unit, active clients, gateway and paper operation are unchanged. ai-memory retains coding memory.
Recall cannot hard-filter by time and never supplies point-in-time exclusion for backtests. Same-record restart/restore durability and revised-template crash recovery remain unqualified until their separately owned native host checks.
Checklist