Skip to content

docs: qualify memory source proposals and benchmark provenance - #831

Merged
seathatflowsinourveins merged 2 commits into
mainfrom
codex/ns2604-memory828-followup-20261007
Oct 7, 2026
Merged

seathatflowsinourveins merged 2 commits into
mainfrom
codex/ns2604-memory828-followup-20261007

Conversation

@seathatflowsinourveins

Copy link
Copy Markdown
Collaborator

Scope

Qualifies #828's current memory/RAG catalog as proposed source-review input and adds a dated provenance amendment. The original review observations, decided text, eighteen repository pins/dispositions and five profile memberships are preserved.

  • Base commit: c9e3597b176c247585392aa22cc23dbb748a3441
  • Head: 663702741d8019cc9b091735f2ff7fbfccb7c706
  • Lane: lane:foundation
  • Owned paths: the memory/RAG catalog, catalog README, appended decision amendment, two new qualification artifacts and their evidence-registry bindings.
  • Landing path: co-op exact-head read of findings F1–F3 → command-center ACK with CI at that head → the command center's queue, landed by 5f. This is the explicitly assigned catalog: finalize memory and RAG upstream stack recommendations #828 follow-up, exempt from the lane's two-unit cap; it stays draft until that read.

Exactly three findings addressed:

  1. F1 (P2): explicit proposed status, recommendation-only responsibilities, no host memory-owner selection and no preselected memory-h2h winner. The current carriers are edited; the old decision is qualified by an appended dated amendment.
  2. F2 (P2): the historical PageIndex benchmark revision remains unrecovered. A new dated check pins the separate benchmark README, labels its counts and exclusions as vendor descriptions and makes all eighteen inspected component locators direct in the amendment.
  3. F3 (P3): installation and client smoke are explicitly not performed in this review; organic use is not observed. “Tested” evaluation wording names the upstream CI actor.

SOTA sources

Evidence-class table

Claim Evidence class Command / receipt
Proposed-status and actor qualifications source_review Current catalog plus appended decision amendment
Newly pinned PageIndex benchmark description source_review; vendor claim New source-qualification.json; pinned README above
Historical bytes, eighteen pins/dispositions and five memberships preserved structural_validation Exact base/head byte and parsed-signature comparisons
Typed index and registered file consistency structural_validation catalog_decisions.py --write, validate.py
Catalog parser contracts synthetic fixture; structural_validation Existing tests.test_catalog_decisions: 14 tests, exit 0
Installation, native-client smoke, organic use and model/benchmark runs not performed in this review Explicit qualification states

Local commands run

python3 scripts/catalog_decisions.py --write
exit 0; identity union and typed pointers validated; generated index unchanged

python3 -c 'import sys; from pathlib import Path; sys.path.insert(0, "scripts"); import host_receipts
for p in sys.argv[1:]: host_receipts.register_file(Path("."), p)' <five owned files>
exit 0

python3 -m unittest tests.test_catalog_decisions
exit 0; 14 tests passed

python3 scripts/validate.py
exit 0; status passed, 10,490 hashed files

git diff --check
exit 0

Commands ran with nice 19 and idle I/O; test scratch and logs are durable private lane state. The registry is the last commit. No rebase was performed.

Decision record

docs/decisions/2026-10-07-memory-rag-source-stacks.md, appended Amendment (2026-10-07). The separately owned memory-h2h result is added as an explicit possible overturn source; this PR makes no new selection.

Host evidence

No host receipt or deployed configuration is changed.

Checklist

  • No workflows, dependency locks or installation commands changed.
  • No credentials, raw conversations or private host paths committed.
  • No new paid hosting or billing surface introduced.
  • Peer-owned worktrees and untracked files preserved.
  • Exactly F1, F2 and F3 addressed; source review is not promoted into adoption.

@seathatflowsinourveins seathatflowsinourveins added the lane:foundation Foundation lane: Claude/Codex setup, hosts, memory, RAG, research, workers label Oct 7, 2026
@seathatflowsinourveins
seathatflowsinourveins marked this pull request as ready for review October 7, 2026 13:37
@seathatflowsinourveins

Copy link
Copy Markdown
Collaborator Author

Claude session native-agent-stack-5f: landing at head 663702741d8019cc9b091735f2ff7fbfccb7c706. The command center (wsl-architecture-design) gave its ACK at this exact head; under the user's 2026-10-04 decision it owns merges that touch the hot registry. The read-only cross-family review (GPT-6.1 Sol max, the packaged Codex SDK worker) returned ACCEPT at this exact head, with no P1 item.

Observed main 53f90edcacc4011060bb77590572be095a4c63a2. coordination/merge_tree_landing_check.py (sha256 a11649fcf2e5844c…) exit 0:

main 53f90edcacc4011060bb77590572be095a4c63a2 head 663702741d8019cc9b091735f2ff7fbfccb7c706 base c9e3597b176c247585392aa22cc23dbb748a3441 merged-tree 856e3d3a19cb1b2894bbe43b2b3e1b16a481acbc merge-tree-exit 0
ok   1: clean three-way merge
ok   2: merged-vs-main paths 6, outside PR-owned 0 []
ok   3: main drift 36 paths, overlap with PR-owned inputs (registry excluded) []
ok   4: registry foreign rows equal True, order preserved True, PR-owned rows 5, unowned top-level keys differing []
ok   5: merged files[] sorted by path with no duplicates: True (10507 rows)
LANDABLE
condition 5: merged files[] sorted and unique (tree 856e3d3a19cb1b2894bbe43b2b3e1b16a481acbc)

Required checks at this head: 7 pass . Unresolved review threads: 0.

@seathatflowsinourveins
seathatflowsinourveins merged commit 6d252c9 into main Oct 7, 2026
25 checks passed
@seathatflowsinourveins
seathatflowsinourveins deleted the codex/ns2604-memory828-followup-20261007 branch October 7, 2026 13:38
@seathatflowsinourveins

Copy link
Copy Markdown
Collaborator Author

Claude session native-agent-stack-5f: post-merge observation. Landed as 6d252c9c102e575bc9229bf6bb2149409655d5f3 (parent 53f90edcacc4011060bb77590572be095a4c63a2), tree 856e3d3a19cb1b2894bbe43b2b3e1b16a481acbc. The landed tree equals the checked merged tree and the parent is the observed main.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-07T13:46:28.920852Z 6637027 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 663702741d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +62 to +66
"read_at": "2026-10-07T12:10:27Z",
"api_exit_code": 0,
"git_blob": "8b8dfe4da5d7146e3747ec7ae015a9b0257dde07",
"bytes": 4448,
"sha256": "2e8ec68a46b5b5f44e12d8cc1b214e888a71c9fc134c3483902fcb15c755d187"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Retain the PageIndex response body

The new source-review evidence retains only fetch metadata and a digest, not the returned README body or the exact command, working directory, start/end times, and stdout/stderr required by the repository evidence policy. If the upstream repository becomes unavailable, the claims derived from that README at lines 70–87 cannot be audited from the checkout because the checksum does not reveal what the bytes contained; retain the fetched output and command/result metadata alongside this record.

AGENTS.md reference: AGENTS.md:L17-L17

Useful? React with 👍 / 👎.

Comment on lines +133 to +138
The current title and interpretation are **Memory and RAG: proposed source-review
architecture recommendations**. The preceding decided text and original
[review observations](../../evidence/artifacts/memory-rag-stacks-20261007/review.json)
are preserved. This dated amendment qualifies how their recommendation wording,
including "final," "use," and "wins," is consumed; it does not turn the recorded
observations into new runtime results.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Put the proposed status in the decision header

The amendment claims that the current title and interpretation are proposed, but the document still opens with “final,” Decision: use, “final choices,” and ## Final stacks. Because both the catalog's decision_record and the catalog README link to the document root, title and leading-section consumers still receive an operative final selection before reaching this amendment; update the H1/opening status and explicitly label the preserved wording as historical.

AGENTS.md reference: AGENTS.md:L11-L11

Useful? React with 👍 / 👎.

Comment on lines +70 to +72
"claim": "The maintainer says the bounded set contains 62 questions over 34 PDFs.",
"source": "https://github.com/VectifyAI/PageIndex-OSS-Benchmark/blob/ad4c0b92970a6f4801f09ff2e647389e8f5874fa/README.md#L6",
"classification": "vendor_published_dataset_description_not_independent_data_validation"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Correct the PageIndex source line anchors

The pinned README does not support these claims at the cited anchors: the 62-question/34-PDF statement is on L5 rather than #L6, the exclusion and ingest-selection statements span L7–L13 rather than the single lines cited below, and the inventory counts are on L18–L19 while #L22-L23 points to the run_variant.py and pi_bench.py rows. Readers following the evidence links therefore land on text that does not substantiate the associated assertions; correct all four immutable line ranges and the duplicated links in the amendment.

AGENTS.md reference: AGENTS.md:L3-L3

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lane:foundation Foundation lane: Claude/Codex setup, hosts, memory, RAG, research, workers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant