Repository navigation
docs: qualify memory source proposals and benchmark provenance - #831
Conversation
|
Claude session native-agent-stack-5f: landing at head Observed main Required checks at this head: 7 pass . Unresolved review threads: 0. |
|
Claude session native-agent-stack-5f: post-merge observation. Landed as |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 663702741d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "read_at": "2026-10-07T12:10:27Z", | ||
| "api_exit_code": 0, | ||
| "git_blob": "8b8dfe4da5d7146e3747ec7ae015a9b0257dde07", | ||
| "bytes": 4448, | ||
| "sha256": "2e8ec68a46b5b5f44e12d8cc1b214e888a71c9fc134c3483902fcb15c755d187" |
There was a problem hiding this comment.
Retain the PageIndex response body
The new source-review evidence retains only fetch metadata and a digest, not the returned README body or the exact command, working directory, start/end times, and stdout/stderr required by the repository evidence policy. If the upstream repository becomes unavailable, the claims derived from that README at lines 70–87 cannot be audited from the checkout because the checksum does not reveal what the bytes contained; retain the fetched output and command/result metadata alongside this record.
AGENTS.md reference: AGENTS.md:L17-L17
Useful? React with 👍 / 👎.
| The current title and interpretation are **Memory and RAG: proposed source-review | ||
| architecture recommendations**. The preceding decided text and original | ||
| [review observations](../../evidence/artifacts/memory-rag-stacks-20261007/review.json) | ||
| are preserved. This dated amendment qualifies how their recommendation wording, | ||
| including "final," "use," and "wins," is consumed; it does not turn the recorded | ||
| observations into new runtime results. |
There was a problem hiding this comment.
Put the proposed status in the decision header
The amendment claims that the current title and interpretation are proposed, but the document still opens with “final,” Decision: use, “final choices,” and ## Final stacks. Because both the catalog's decision_record and the catalog README link to the document root, title and leading-section consumers still receive an operative final selection before reaching this amendment; update the H1/opening status and explicitly label the preserved wording as historical.
AGENTS.md reference: AGENTS.md:L11-L11
Useful? React with 👍 / 👎.
| "claim": "The maintainer says the bounded set contains 62 questions over 34 PDFs.", | ||
| "source": "https://github.com/VectifyAI/PageIndex-OSS-Benchmark/blob/ad4c0b92970a6f4801f09ff2e647389e8f5874fa/README.md#L6", | ||
| "classification": "vendor_published_dataset_description_not_independent_data_validation" |
There was a problem hiding this comment.
Correct the PageIndex source line anchors
The pinned README does not support these claims at the cited anchors: the 62-question/34-PDF statement is on L5 rather than #L6, the exclusion and ingest-selection statements span L7–L13 rather than the single lines cited below, and the inventory counts are on L18–L19 while #L22-L23 points to the run_variant.py and pi_bench.py rows. Readers following the evidence links therefore land on text that does not substantiate the associated assertions; correct all four immutable line ranges and the duplicated links in the amendment.
AGENTS.md reference: AGENTS.md:L3-L3
Useful? React with 👍 / 👎.
Scope
Qualifies #828's current memory/RAG catalog as proposed source-review input and adds a dated provenance amendment. The original review observations, decided text, eighteen repository pins/dispositions and five profile memberships are preserved.
c9e3597b176c247585392aa22cc23dbb748a3441663702741d8019cc9b091735f2ff7fbfccb7c706lane:foundationExactly three findings addressed:
SOTA sources
Evidence-class table
source-qualification.json; pinned README abovecatalog_decisions.py --write,validate.pytests.test_catalog_decisions: 14 tests, exit 0Local commands run
Commands ran with nice 19 and idle I/O; test scratch and logs are durable private lane state. The registry is the last commit. No rebase was performed.
Decision record
docs/decisions/2026-10-07-memory-rag-source-stacks.md, appended Amendment (2026-10-07). The separately owned memory-h2h result is added as an explicit possible overturn source; this PR makes no new selection.Host evidence
No host receipt or deployed configuration is changed.
Checklist