Repository navigation
Require the promotion-gate result to report every named gate check (SYN) - #77
Merged
seathatflowsinourveins merged 5 commits intoSep 23, 2026
Merged
Conversation
Blind Codex review of #64: the paper preflight accepted a gate result with an unnamed passing check, null versions and null checked_at. It now requires the checks to name every promotion_gate.CHECK_NAMES entry exactly once, a non-empty versions object and an ISO-8601 checked_at (else promotion_gate_incomplete). A test parses promotion_gate.py so the two lists cannot drift. The real 2026-09-22 gate result and the good fixture still pass. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
… row binding Review follow-ups on eb2e9c8: a non-string check name is refused cleanly instead of raising TypeError; checked_at must be a timezone-aware ISO-8601 date-time; version values must be non-empty strings; for a .csv snapshot row_count must equal the file's data rows; an unmapped_failures entry from the gate raises promotion_gate_unmapped_failures (peer suggestion). Mutations of the name-set guard and the row binding each fail their tests. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Second review of the gate check: the CSV row count re-read the snapshot outside the OSError guard; hash and count now use the same bytes. Receipt limits name the quoted multi-line CSV false-refusal case. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
…-completeness-20260922 # Conflicts: # docs/ecosystem/index.html # manifests/evidence.json
…-completeness-20260922 # Conflicts: # docs/ecosystem/index.html # manifests/evidence.json
seathatflowsinourveins
deleted the
claude/promotion-gate-completeness-20260922
branch
September 25, 2026 18:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runner._check_promotion_gate. A gate result withchecks=[{status:'pass'}],row_count=1,versions=null,checked_at=nulland the matching hash of a header-only CSV passed the paper preflight.checksto name everypromotion_gate.CHECK_NAMESentry exactly once, with no missing, extra, unnamed or duplicate checks;versionsto be a non-empty object;checked_atto be an ISO-8601 timestamp.Anything else raises
promotion_gate_incomplete. The failed-check and empty-row checks are unchanged._full_gate_resultnow emits the gate's full check list.test_runner_check_names_match_the_gate_moduleparsespromotion_gate.py, so the runner's list cannot drift from the gate's.promotion_gate.pyare the peer's separate branch.Evidence (SYN)
PromotionGatePreflight+MainCommandGateWiring+OvernightHoldPreflightScope: 40 OK.fixtures/good-gate-result.jsonare still accepted.python3 -m unittest: 2043 OK (324 skipped). Engine interpreter: 2043 OK (7 skipped).validate.ymlsteps andtrading_gates.py --checkrc=0.promotion_gate_completenessadded; source-hashes, manifest and explorer repinned.🤖 Generated with Claude Code