Repository navigation
Retire PR #320 without merging its Loki and host receipt changes - #651
Conversation
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
A22 partially overlaps the component evidence matrix (the matrix counts receipts only for layer winners; A22 covered every token-efficiency component), and its reopen condition names that gap; the ccusage half of the target/legacy point is attributed to clean-resolution L25 and definitive-defaults L78; the README anchor covers L142-164; the head and branch stay preserved after closure; the privacy note lists the two public upstream documentation URLs. Co-Authored-By: Claude Opus 5.5 <[email protected]>
…in's plus the record's re-registered row (hot-file protocol) Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
Claude session native-agent-stack-0c: the independent Opus review (verdict: repair, 1 should-fix and 4 minor) is applied at head
Checks at this head, all exit 0: Residuals: none from the review. This PR merges once its required checks pass at this head. #320 is then closed with a comment citing the merged record, and its branch is kept. |
|
Exact-head SOURCE ACCEPT at The pinned record preserves proposal I checked the publication against original pinned proposal and main sources. The proposed receipt display filters for agreement before selecting latest evidence, so it can hide a newer dissent; the existing matrix publishes winners, rather than every token-stack component. The corrected partial-overlap explanation and the binding/failure boundaries avoid claiming that the matrix already supplies all proposed receipt rows. The proposal's page-boundary quote matches its original joined source strings. All eleven inspected citations at authored record base The record keeps selected-target/legacy-host scope separate, leaves live Loki reconciliation and publication acceptance unestablished, and preserves the observation owner's deciding measurement. Its reopen conditions call for current version-bound primary sources and complete response/recovery and evidence-binding checks if either proposal becomes needed. The current unpinned public monitoring/API pages are explicitly discovery leads; they supply no installed acceptance. Actual complete tree comparison changes only this decision document and P3 publication cleanup: the PR body's integration base and “independent Opus review pending” text lag the actual base and owner's repair report. Update that description; keep the reported review classified as an owner report unless its original output, hash and usage custody are published. That original review was not supplied in the queried changed files/comments, and I did not open private review logs. The objection-window wording records the owner's decision; this source ACCEPT does not turn silence into a new approval or attest that closure has occurred. Source ACCEPT covers faithful failed-proposal retirement and recovery boundaries. It supplies no repaired #320 behavior, observation winner, runtime qualification or fresh CI pass. Required hosted checks, fresh-main registry composition and the coordinator's actual post-merge closure remain separate completion steps. Source capture manifest SHA256 |
|
Claude session native-agent-stack-0c: landing at the root-ACCEPTed head Observed main Required checks at this head: 8 pass . Unresolved review threads: 0. |
|
Claude session native-agent-stack-0c: post-merge observation. Landed as |
…-pin-20261003 Refresh onto main cac8700 (#651, #628, #647, #661, #648) under the docs/lanes.md hot-file protocol. - Handbook: main's docs/new-wsl-handbook.{md,json} and evidence/artifacts/new-wsl-handbook-20261001/receipt.json (#647) are the base; scripts/build_new_wsl_handbook.py --write regenerates both outputs with this PR's profile, and the receipt's two outputs hashes and profile_sha256 follow the regenerated files and the profile. Nothing else in the receipt changes. - manifests/evidence.json: three-way registry merge (main's rows kept, this branch's rows applied, the 87 branch-touched files rehashed from the merged tree). - #628's Codex SDK worker pins openai-codex and openai-codex-cli-bin 0.160.0 with the same artifact hash sets as adoption/sdk/requirements-linux-x86_64-py313.lock and cites rust-v0.160.0 a956835d; it changes none of manifests/stack.json, adoption/pins-linux-x86_64.json, tools/adoption/apply_codex_lane.py or adoption/templates. Co-Authored-By: Claude Opus 5.5 <[email protected]>
… does (CI flake on #651, #660) (#665) * K4 timing: time check() with the cyclic collector off, as timeit does test_k4_timing failed intermittently on CI (runs 37128354547 and 37120736604, attempt 1) because a full generation-2 collection landed inside the 100k-character helper window in every round. That pause costs in proportion to the whole test process's heap, not to the input, so it is not the helper's work. Wrap the timed guard.check(text) in the helper rounds (measure_round) and in the nesting probe with gc.disable(), restoring the prior gc.isenabled() state in finally, exactly as CPython's timeit.Timer.timeit does (Lib/timeit.py L177-183 at 3.12 branch 58ed60b7415e; Doc/library/timeit.rst L136-141). Bounds, sizes, rounds, the exponent, the allowance, calibration and scripts/hooks/secret_path_guard.py are unchanged. docs/secret-storage.md records the practice in the timing method. Co-Authored-By: Claude Opus 5.5 <[email protected]> * Evidence: K4 timing CI flake diagnosis and the collector-off fix evidence/artifacts/k4-timing-gc-20261003/summary.json records, without host paths: - the attempt-1 CI failures of runs 37128354547 (#660) and 37120736604 (#651): helper minima double from 25k to 50k, then jump 5.9-8.1 times to 100k in every round (test exponents 1.508, 1.588, 1.534); - the local reproduction on Python 3.12.3: the unchanged test failing in simulated large heaps (1.819, 1.652, 1.617), the fixed test passing in the same heaps (paired re-run: maximum over all 67 helpers 0.944-1.051, no helper needing a second round), and a quadratic k4_shell_words mutant still rejected with the collector off (1.630, 1.635); - the gc-callback attribution: all 7 collector-on failures had one generation-2 collection in the 100k window in every round (72.1-110.4 ms); the 14 collector-off twins passed in round 1 (0.665-0.848); - linearity with the collector off to 400k (raw pair exponents 0.984-1.054), the rejected alternatives and the evidence classes. Co-Authored-By: Claude Opus 5.5 <[email protected]> * Register the K4 timing change in manifests/evidence.json (hot-file commit, last) Re-hash tests/test_secret_path_guard.py and docs/secret-storage.md and add evidence/artifacts/k4-timing-gc-20261003/summary.json with host_receipts.register_file. Co-Authored-By: Claude Opus 5.5 <[email protected]> * K4 timing evidence: review round 1 repairs to the record From the independent review of #665 at cc19f03 (no defect in the code change; four should-fix inaccuracies in the record): - ci_signature now gives per-round ranges (50k/25k 1.91-2.01, 100k/50k 5.93-8.54, 100k excess over twice the same round's 50k time 69.63-80.76 ms, up to 82.49 ms over twice the 50k minimum) apart from the per-size minima the test decides on (1.97-1.98, 5.93-8.06, 69.63-76.29 ms); the minima fields are named as minima. - overturn_conditions added: a CI full-suite run where the fixed test still fails on growth, an allocation-heavy guard change whose collection cost grows with the input, or upstream timeit changing its gc practice. - python.ci cites "Using CPython 3.12.3 interpreter at: /usr/bin/python3" from both failing job logs (lines 1503 and 1509). - gc_callback_attribution states its scope (14 replays, 7 heaps; the 7 listed twins span 0.708-0.841, all 14 collector-off decisions 0.665-0.848); evidence_classes now cover the attribution, linearity and collector-on direct-call sections. gcmodule.c L1441 (the generation-count threshold) is cited beside L1479. - docs/secret-storage.md: no collection of any generation runs inside a timed window. Co-Authored-By: Claude Opus 5.5 <[email protected]> * Re-register the K4 timing record repairs in manifests/evidence.json (hot-file commit, last) Re-hash docs/secret-storage.md and evidence/artifacts/k4-timing-gc-20261003/summary.json with host_receipts.register_file; tests/test_secret_path_guard.py is unchanged. Co-Authored-By: Claude Opus 5.5 <[email protected]> --------- Co-authored-by: Scout <scout@local> Co-authored-by: Claude Opus 5.5 <[email protected]>
Scope
9b0b8d6d25f9e3fb8f71770500e774170423315e.lane:foundation.docs/decisions/2026-10-03-retire-pr320-loki-denominator-host-receipts.mdandmanifests/evidence.json. Both prescribed generators were run; their four reports remain byte-identical to the base.10:21:52Zwithout a reply. Preserved proposal head:d59d0fca32a820bc19a58dc78f27148ddeb9c142, branchclaude/token-practice-reporting-20260925, recoverable throughgit fetch origin pull/320/head.SOTA sources
9b0b8d6d25f9e3fb8f71770500e774170423315e: the dated retirement style indocs/decisions/2026-09-25-retire-vela-velanext.md; target-versus-legacy scope indocs/decisions/2026-10-02-clean-resolution-goal.md; the ccusage/context-supply/Loki/Grafana rows and observation measurement indocs/decisions/2026-10-01-new-wsl-definitive-defaults.md;docs/token-practice.md's September 29 accounting;tools/token-report/README.md's optional upstream reports; the component matrix andscripts/platform_status.py/scripts/receipt_staleness.pydocstrings; the September 27 fail-closed anti-pattern indocs/harness-defaults.md.d59d0fca32a820bc19a58dc78f27148ddeb9c142:tools/token-report/token_manifest.py, its README,scripts/build_ecosystem.pyanddocs/ecosystem/template.html; builder/template diff from the proposal's stated base5d8bd611. The record links the exact source lines.docs/lanes.md's hot-file protocol and the existingscripts/host_receipts.pyregistration and native generator/check commands at the pinned record base. No runtime or harness is added.Evidence-class table
source_review— repository records and source readslocal_integrationLocal commands run
The builder executed each command with RTK; every exit shown is the actual command/process return. Registry preparation:
The author's separate read-only comparison returned exit 0 for verbatim findings/boundary, exact query, clean whitespace, no private locators and one hash/byte-matched registration with all existing registry data identical. It is source consistency, not independent review. The coordinator must repeat the two branch-diff commands after committing and run
gh pr checks <this PR> --requiredon the final reviewed head, checking every required context's passing bucket and count.Decision record
docs/decisions/2026-10-03-retire-pr320-loki-denominator-host-receipts.mdrecords the evidence, merge/repair/retire alternatives and the deciding observation/evidence-view requirements that would reopen A20/A22. It preserves the proposal's head and recovery ref. All eight original review findings remain requirements for a rebuild.Host evidence
No host receipt is added or changed. The host-receipt validator passed for the existing registry. This record changes no
platform_statusand makes no new host/model/GPU acceptance claim.Checklist
--match-head-commit(coordinator-owned).Residual evidence wording: the later hold says a Claude-family review of this head was not done; the PR body claims earlier Opus evidence-review rounds. The record preserves that difference rather than claiming no earlier review ever existed. The eight ecosystem pin-drift observations are unchanged metadata outside this branch's ownership. Neither is concealed as a fresh acceptance result.
🤖 Generated with Claude Code