Repository navigation
Hand off minimal decision routing through its instruction source owner - #571
Merged
seathatflowsinourveins merged 2 commits intoOct 1, 2026
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0071c67c19
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
seathatflowsinourveins
force-pushed
the
codex/minimal-owned-source-sync-20261001
branch
from
October 1, 2026 08:02
0071c67 to
251209c
Compare
seathatflowsinourveins
force-pushed
the
codex/minimal-owned-source-sync-20261001
branch
from
October 1, 2026 08:39
251209c to
9b85338
Compare
seathatflowsinourveins
deleted the
codex/minimal-owned-source-sync-20261001
branch
October 1, 2026 09:24
This was referenced Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
On a host whose personal directives are generated by another source owner, the previous full-pack helper appended another 56/62-line defaults/RTK pack. Export only the existing three-line decision-routing fragment, refuse generated personal output, and preview only an instruction source the caller already owns.
decision-mdnever writes, backs up or replaces a target; the producer owns mutation.5597f9fae2c6148037a74b4e73d2c55fc11c9ff6lane:foundationadoption/templates/decision-routing.md,adoption/update.md, the dated decision and one anti-pattern row indocs/,tools/adoption/managed_block.py, the explicit caller inadoption/bootstrap-linux.sh, and regression coverage intests/test_managed_block.py/tests/test_bootstrap_full_profile.py;manifests/evidence.jsononly registers their hashes in the last commit.The Mac handoff exports the fragment to the separate
agent-ecosystemproducer owner. This PR neither edits that producer nor installs directives/catalog data on the Mac. Its reviewed producer has no selective installed-registry command: broadcatalog_refresh.py --applyinvokes the full installer and preserves decision/import pins. The producer owner must reconcile maintained selections/retired-host routes and qualify a receipt-aware selective synchronization path there. No replacement registry is synthesized.SOTA sources
managed_block.pysupplies native Markdown marker parsing and preview behavior.apply_claude_settings.pyis unchanged from the base; the new writer was removed because a check followed by replacement cannot guarantee atomic compare-and-swap. Bootstrap passes its existing home-scoped Claude target explicitly. The fragment is checked against the unchanged canonical Codex template paragraph.Evidence-class table
tests.test_managed_block.DecisionMdBlockTests753777ac8163332a3570888680893821439ee4ab; Mac provenance is owner-reportedLocal commands run
Decision record
docs/decisions/2026-10-01-minimal-owned-source-sync.mdrecords the reported duplication, alternatives, producer boundary, citations and conditions that reopen this choice. Original local failed fixture/doc checks were diagnosed and retained in the cloud logs; assertions were not weakened.Independent read-only reviews covered the producer interfaces, evidence scope, instruction formats and write safety. Final read-only review found no unresolved material blocker after addressing the three GitHub review findings; source commit
c1a6585dc7d859da7cc36771d2ee67062084fa22binds the reviewed content. Export/preview only removes the unsafe writer; normalized paragraphs detect wrapped copies; the integrated bootstrap caller supplies its intended target. Earlier passed checks at0071c67cdo not qualify the corrected head.The reported Mac production remains ai-memory 2.5.0 / Ollama 0.34.4; Hindsight 0.10.2 remains isolated. The 20-pass/2-failure lifecycle and the 20-second mismatch remain open despite the later two parsed-JSON diagnostic calls. Measured and blind promotion gates, native caching/compaction, models/effort, QMD relevance failure and surviving-host preregistration remain intact.
Host evidence
No files under
evidence/hosts/changed. The sanitized owner handoff is reported host evidence, not execution by this cloud task.Checklist