Repository navigation
Mover v3 core: resolve the independent pre-outcome review (round 8, not frozen) - #192
seathatflowsinourveins wants to merge 2 commits into
Conversation
…ot frozen) Resolves findings F01-F15 of the 2026-09-24 cross-family review (Codex CLI 0.155.0-alpha.16.3, GPT-6 family) of core sha256 7274c29e and README 5728609b, one dated review_record entry per finding: - F01 record-based dividend cash, explicit split accounting (R, F*, F_acc), spin-off and unrecorded-distribution exclusions, accounting identity - F02 completed-bar cumulative dollar volume for the cost tier - F03 one cohort per coverage rate, fail-closed empty/unavailable cohorts - F04 count run bound to spec_sha256, study tree and input manifest; enumerated metadata-only paths; freeze_record and run_entries - F05 count_unit equals final analyzability; terminal-merger bid defined - F06 occupied-session minima and degenerate-bootstrap rules - F07 separate primary and profitability verdicts - F08 per-input availability/vintage rule and sealed holdout capture - F09 normalized identity probe, unresolved reuse, decision-time dedup - F10 embargo for every item and 10-session blocks - F11 purpose-specific authorization matrix - F12 conservative full-pipeline fetch budget with separate quotas - F13 snapshot-part permissions; F14 MDE units; F15 freeze_acceptance Also records the LPS 2019 full-text read in freeze_preconditions[1] and removes every ABJK 2022 claim; adds the fee row date bases and the amendment line format requested from the data-file PR #186 (its files are not changed here). Status moves to draft_pending_independent_verification_of_review_resolutions; frozen_before_outcomes stays false. No market data fetched, no sealed data opened, no outcome computed. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
…ptance item 2) Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Superseded by #190 — kept as a draft for reference, will not be merged. This PR resolved the independent Codex review (F01-F15, posted on #174) against the core draft on 🤖 Generated with Claude Code |
|
Closing as superseded by #190, per this PR's own 2026-09-24 note ("Superseded by #190 — kept as a draft for reference, will not be merged"). The trading owner acknowledged the closure. The branch is kept, so this can be reopened if needed. Part of the 2026-09-25 repository noise cleanup approved by the repository owner. |
Append the owner's 2026-10-12 foundation rule to the end of the "Decide by evidence" bullet on all six always-loaded rule surfaces: AGENTS.md, the portable Claude block, the Codex template, the scaffold and the two new-WSL carriers, regenerated with new_wsl_client_config.py --write-blocks. A tool, runtime, model or skill is installed, run or made a default only after the layer's own convergence passes it; popularity, recency and vendor claims make it a lead, never an admission. - tests: a fail-first test that every layer and native renderer ends the bullet with the sentence once (9 failing subtests before the edit); CORE updated; the Codex top-rule pin re-derived with template_segments() (2,607 bytes); the startup byte ceilings raised by a dated comparison to 7,548/7,654. - docs/decisions/2026-10-12-converged-candidates-only.md: the rule, its basis (owner direction, CC ruling addendum-01 with correction #192, the existing evidence rule), what it changes, surfaces, budget comparison, checks and overturn conditions. Supersession: none. - manifests/evidence.json: the changed files registered with register_file. Co-Authored-By: Claude Opus 5.5 <[email protected]>
…ly through a converged harness (#1049) * Rule text: use only converged candidates (foundation rule) Append the owner's 2026-10-12 foundation rule to the end of the "Decide by evidence" bullet on all six always-loaded rule surfaces: AGENTS.md, the portable Claude block, the Codex template, the scaffold and the two new-WSL carriers, regenerated with new_wsl_client_config.py --write-blocks. A tool, runtime, model or skill is installed, run or made a default only after the layer's own convergence passes it; popularity, recency and vendor claims make it a lead, never an admission. - tests: a fail-first test that every layer and native renderer ends the bullet with the sentence once (9 failing subtests before the edit); CORE updated; the Codex top-rule pin re-derived with template_segments() (2,607 bytes); the startup byte ceilings raised by a dated comparison to 7,548/7,654. - docs/decisions/2026-10-12-converged-candidates-only.md: the rule, its basis (owner direction, CC ruling addendum-01 with correction #192, the existing evidence rule), what it changes, surfaces, budget comparison, checks and overturn conditions. Supersession: none. - manifests/evidence.json: the changed files registered with register_file. Co-Authored-By: Claude Opus 5.5 <[email protected]> * Rule text: use models only through a converged harness Append the owner's second 2026-10-12 foundation rule (20:15Z direction) right after the converged-candidates sentence, at the end of the "Decide by evidence" bullet, on all six rule surfaces; the two new-WSL carriers regenerated with new_wsl_client_config.py --write-blocks. A model runs only inside a converged harness with its full layers; a bare API call is for measurement probes and smokes only, recorded as such. - tests: the presence test now covers both sentences, in order (9 failing subtests before this edit); CORE updated; the Codex top-rule pin re-derived with template_segments() (2,860 bytes); the startup ceilings raised by the dated comparison to 8,079/8,185. - docs/decisions/2026-10-12-converged-candidates-only.md: the second sentence, its basis (owner direction 20:15Z, CC runtime-roadmap ruling), its change, the budget table and checks for both steps. - manifests/evidence.json: the changed files re-registered. Co-Authored-By: Claude Opus 5.5 <[email protected]> * Rule text: a screen pass admits a trial; a default needs a measured win Tighten the converged-candidates sentence on all six rule surfaces, on the CC's direction: a candidate is installed or run for trial only after the layer's own screen passes it, and becomes a default only after a measured win on quality at no higher cost. The Stage A screen checks documented capability at a pin and runs nothing, so a pass is not quality evidence. The harness sentence after it is unchanged; the two new-WSL carriers regenerated with new_wsl_client_config.py --write-blocks. - tests: CONVERGED (and with it CORE) carries the new wording; the presence test failed first (9 subtests); the Codex top-rule pin re-derived with template_segments() (2,864 bytes); the startup ceilings re-derived to 8,088/8,194. - docs/decisions/2026-10-12-converged-candidates-only.md: the new wording, the earlier wording it replaces before landing, why a screen pass is trial-only (CC runtime-profiles addendum-01, Stage A and B), the budget table and checks. - manifests/evidence.json: the changed files re-registered. Co-Authored-By: Claude Opus 5.5 <[email protected]> * Rule text: defaults need multi-angle convergence; one angle never admits Final wording on the owner's 20:29Z direction (CC multi-angle convergence ruling): on all six rule surfaces, the converged-candidates sentence now admits a trial after the layer's screen and a default only when the layer's multi-angle convergence agrees (capability at the pin, upstream engineering quality, community consensus, net usage, published evaluations and our own measured runs); where angles disagree, the disputed dimension is measured first-hand, and no single angle admits a candidate. The bullet's not-evidence clause reads "alone are not evidence". The harness sentence is unchanged; the two new-WSL carriers regenerated with new_wsl_client_config.py --write-blocks. - tests: CONVERGED and CORE carry the final wording; the presence test also checks the "alone" clause in place and the old clause absent (9 failing subtests before the edit); PROCEDURE_PHRASES updated; the Codex top-rule pin re-derived (3,017 bytes); the startup ceilings re-derived to 8,409/8,515. - docs/decisions/2026-10-12-converged-candidates-only.md: rewritten for the final text, with the branch's earlier wordings, the multi-angle basis and supersession, the budget comparison and every check. - manifests/evidence.json: the changed files re-registered. Co-Authored-By: Claude Opus 5.5 <[email protected]> * Record: how the rule applies to every layer, the freeze and the north star Add "How the rule applies: every layer, the freeze and the north star" to docs/decisions/2026-10-12-converged-candidates-only.md, on the CC's direction: the six angles and per-layer weights, the scope across both repositories, the wave cycle, the freeze in final-stack.json (current counts: converged 0, reopened 30, no-winner 2, unswept 2; no angle weights), what scripts/final_stack.py and CI check today, the revisit triggers, the SOTA-sources pin rule and the trading north star. Facts cited path:line at main 489b263, byte-identical at the base. No rule surface, pin or ceiling changes. - manifests/evidence.json: the record re-registered. Co-Authored-By: Claude Opus 5.5 <[email protected]> * Review round 1: private digests out, licence never a disqualifier, reopen rule as written One commit for both reads of #1049 at ce11fbd (the GPT verdict and the Claude read), after the registry-only rebase onto main 703d588. - GPT P1 (#161): the decision record cites the CC's private rulings by name only, with no path and no digest; the PR body does the same. - GPT P1 (licence): the hard disqualifiers are a missing required capability (an entitlement or terms conflict counts as one) and an abandoned project. Licence is a compliance note (SPDX id, source, read time), per the CC ruling ruling-licence-not-a-disqualifier-20261012. No rule surface named licence. - Claude P2-1: the protocol's reopen rule is quoted as written (a FINAL layer reopens only when a sweep detects a change, bound to that sweep). The angle sources become sweep inputs, a named follow-up to recipes/saturation-sweep.md; review contradictions go through the corrections rule. - Claude P2-2: docs/harness-defaults.md:9 reads "alone are not evidence", pinned by a new test that fails on the old line. - P3s: on all six surfaces "the layer's screen (its requirements checked at a pin)" and "no single angle makes a candidate a default", carriers regenerated with --write-blocks; the presence test failed first (9 subtests); TOP_RULE_SHA256 re-derived (3,051 bytes); the startup ceilings re-derived to 8,480/8,586 with the Codex project_doc_max_bytes primary source (openai/codex rust-v0.162.1, config_toml.rs:75). CI checks angle records only once the freeze-wave PR lands; plans and host reports are labelled as such. - manifests/evidence.json: the changed files re-registered. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Resolves every finding of the independent cross-family pre-outcome review of the Mover v3 core (2026-09-24; Codex CLI 0.155.0-alpha.16.3, GPT-6 family; reviewed core sha256
7274c29e…, README5728609b…; verdict "not ready; conditionally eligible after correction and acceptance evidence"). Each finding has its own datedreview_recordentry (round 8, same{date, round, input, resolution}format as rounds 5-7), plus one entry for the data-file addition from #186.Not a freeze.
statusmoves fromdraft_pending_independent_pre_outcome_reviewtodraft_pending_independent_verification_of_review_resolutions;frozen_before_outcomesstaysfalse;freeze_recordisnull. No market data was fetched, no sealed data opened and no outcome computed.allbooks spin-offs as cashcash_dividendrecords (rate x F_acc(e, j-1), no price input). Split accounting is explicit (bars snapped to the recorded ratio). Spin-off, stock-dividend, rights and unit-split records, and unrecorded distributions (q-ratio check), exclude the trade within (e, E]; after E they are booked at zero. A synthetic identity checks that no price after the exit changes the returnpopulations.corporate_actions,populations.formulas(R, F*, F_acc, q),populations.suspected_unadjusted_split,arms.c_decompositioncum_dv(X)counts completed bars only (bar start + 60 s <= X); boundary testspopulations.formulas,cost_model.lookup.cell_key,relation_to_prior_protocolscoverage_rule.year_rulecoverage_rulehash-boundspec_sha256(the whole protocol minus enumerated metadata paths), its study tree and its input manifest. All three must match at the freezecoverage_rule.decided_by_code,exposure_registry.run_entries,freeze_record,run_discipline.study_codecount_unitcounts exactly the analyzable observations (flags only) and carries n and occupied sessions. The read's count governs minima and MDE. A terminal-merger bid always existschronology.holdout.count_unit,populations.terminal_exits.booking,minimum_detectable_effect.formulaminimum_sample.occupied_sessions,statistics.degenerate,statistics.p_value,statistics.normal_tail_poutcome_reporting.hypothesis_verdictuniverse_and_identity.availability,holdout_gate.prospective_collection,outcome_reporting.qualifiersexposure_registry.pre_freeze_access_path.identity_probe,universe_and_identity.dedupchronology.boundaries,statistics.bootstrapholdout_gate.evaluator_refusals,holdout_gate.access_logfreeze_preconditions[5],exposure_registry.pre_freeze_access_path.outputsexposure_registry.pre_freeze_access_path.snapshot_part_permissions,.ruleminimum_detectable_effect.units,.reading,statistics.estimatorfreeze_acceptanceLiterature (freeze_preconditions[1], met). LPS 2019 was read in full from the author-hosted publisher PDF (sha256
caa7108c…, 2026-09-24). ABJK 2022 could not be obtained (closed access), so every claim that depended on it was removed from README (evidence row, H3 basis, open questions) and fromitem_set.items[4].why_kept, using the read record's wording.Data-file addition (#186, merged as b165579; its files are not touched here).
cost_model.feesnow says which date selects a fee row. SEC Section 31 uses the settlement date: T+2 before 2024-05-28, T+1 from then. FINRA TAF uses the trade date. Boundary tests use the file's own rate boundaries. The section also notes that the SR-FINRA-2026-020/021 TAF pause is already reflected, and that a rate announced before the freeze changes the base file and its pin. The newrun_discipline.amendment_formatdefines both JSON Lines amendment formats (append-only; they never change base files or pins).Checks.
python3 scripts/validate.pyexit 0;python3 scripts/evidence_manifest.py --checkexit 0;validate_catalogs,validate_foundation,landscape,host_receipts validate,build_ecosystem --check,component_matrix --check,new_host_grand_list --checkandbuild_verdicts --checkall exit 0. A cross-reference check found that every dotted protocol path cited in the core and README resolves; the only unresolved tokens are the same 8 as on main, which are file names and a historical reference.manifests/evidence.jsonhas refreshed hashes for the two changed files. Fullpython3 -m unittest, run unsandboxed because the sandbox refuses local port binding: 3,939 tests, 1 failure, 510 skipped (exit 1). The failure,test_adoption_bootstrap_macos.LlamaWrapperQuotingTests.test_install_path_with_shell_syntax_is_data_in_the_wrapper, also fails on unchanged main; it is the macOS SIP issue that #178 addresses.tests.test_validateandtests.test_evidence_manifeston the final tree: 62 tests, OK. A trial merge with the current origin/main (after #186) passesvalidate.py(5,255 hashed files) andevidence_manifest.py --check.Coordination notes.
claude/mover-v3-core-study-20260924already numbers its ownreview_recordrounds 8-14. Whichever lands second must renumber.exposure_registry.update_rule).🤖 Generated with Claude Code