Repository navigation
Give the catalog-freshness job full history so the release-pin tests resolve - #150
Merged
seathatflowsinourveins merged 2 commits intoSep 23, 2026
Merged
Conversation
…resolve #148 pinned release v2026.09.23.1 to 40828df, and tests/test_release_pin_contents.py fails in CI when the pinned commit or tag is missing from the clone. The freshness job runs the project test suite on actions/checkout's default depth-1 clone, so once main moved past the release commit, 4 of 3,501 tests failed, the freshness job failed and the propose job was skipped (run 35931645459). validate.yml and this workflow's own propose job already use fetch-depth: 0; the freshness job now does too. Checks: zizmor no findings; YAML parses; validate.py passed (manifest hash refreshed); tests.test_catalog_freshness_pins, _propose, test_workflow_security_coverage and test_release_pin_contents: 97 OK. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
9 of 22 tasks
…istory WholeSuiteJobsCheckOutFullHistory (tests/test_workflow_hardening.py): any job whose run steps invoke the whole suite (`python3 -m unittest` with no module or -p arguments, or `discover` without -p over the default or tests directory) must set fetch-depth: 0 on its checkout. It currently covers adoption-bootstrap.yml:validate-macos, catalog-freshness.yml:freshness and validate.yml:validate. Mutation check: removing the freshness job's new fetch-depth line makes it fail on catalog-freshness.yml:freshness; restored, it passes. Suggested in review by the GitHub-automation session. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
seathatflowsinourveins
deleted the
claude/freshness-full-history-20260923
branch
September 23, 2026 23:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The catalog-freshness workflow has been failing since #148 (run 35931645459: 4 of 3,501 tests failed, the
freshnessjob failed andproposewas skipped).tests/test_release_pin_contents.pyrequires the pinned release commit40828dfe(v2026.09.23.1) and its tag to resolve in a CI clone. Thefreshnessjob ran the project test suite on the default depth-1 clone, so once main moved past the release commit, that commit was missing.validate.ymland this workflow's ownproposejob already usefetch-depth: 0; this PR adds the same to thefreshnessjob's checkout.Checks: zizmor found nothing;
validate.pypassed (the workflow's manifest hash was refreshed). The workflow, freshness-propose, security-coverage and release-pin test modules: 97 OK. After merge, a dispatch ofcatalog-freshness.ymlshould pass.🤖 Generated with Claude Code