Repository navigation
Make the adaptive-paper tests hermetic from the host STOP kill switch - #137
Merged
seathatflowsinourveins merged 2 commits intoSep 23, 2026
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1ce1ca862a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
9 of 22 tasks
The engine reads safety.DEFAULT_STOP (under the real home state root) at call time, so an owned STOP hold on the host made 32 local tests fail. tests/adaptive_paper_hermetic.py patches DEFAULT_STOP to a per-module temp path in setUpModule and restores it in tearDownModule; the six adaptive-paper and native-fault test modules use it. Per-test patches still shadow it. Engine code is unchanged. With the host STOP present (unchanged size/mtime/md5): 345 tests OK (1 skipped) under the adaptive-paper interpreter, the same with an empty HOME, and 194 OK (31 skipped) under system python3. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
… hash set (Codex review) Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
seathatflowsinourveins
force-pushed
the
claude/hermetic-stop-tests-20260923
branch
from
September 23, 2026 18:47
1ce1ca8 to
16db3e9
Compare
seathatflowsinourveins
deleted the
claude/hermetic-stop-tests-20260923
branch
September 23, 2026 18:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An owned STOP hold on a host (
~/.local/state/native-agent-stack/alpaca-paper/STOP) made 32 local adaptive-paper tests fail, because the engine readssafety.DEFAULT_STOPat call time.tests/adaptive_paper_hermetic.pypatches it to a per-module temp path (setUpModule/tearDownModule) in the six affected modules; per-test patches still shadow it. No engine code changes.Checks, with the host STOP present and unchanged:
HOME.python3 scripts/validate.pypassed; guarded gitleaks onorigin/main..HEAD: no leaks.🤖 Generated with Claude Code