Skip to content

Fail the Codex lane with a setup message when the codex CLI is missing - #133

Merged
seathatflowsinourveins merged 1 commit into
mainfrom
claude/codex-lane-which-20260923
Sep 23, 2026
Merged

seathatflowsinourveins merged 1 commit into
mainfrom
claude/codex-lane-which-20260923

Conversation

@seathatflowsinourveins

@seathatflowsinourveins seathatflowsinourveins commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

On a new WSL or macOS host without the Codex CLI, codex_lane.py raised a FileNotFoundError traceback for every attempt. It now exits 2 with one setup message when layers are pending and codex is not on PATH. This happens before it creates any lane output. --dry-run still prints the commands without the CLI.

The new codex_lane.py hash is appended to lane-provenance.json, which is append-only.

Checks (local, this head)

  • tests.test_verdict_lane_vendoring, tests.test_codex_lane and tests.test_record_verdicts: 137 tests OK. The new MissingCliTests checks exit 2, the message, and that no codex process is started.
  • scripts/validate.py, evidence_manifest.py --check, landscape.py, build_verdicts.py --check and validate_convergence.py --all-recorded: all exit 0.
  • Guarded gitleaks on origin/main..HEAD: no leaks.

🤖 Generated with Claude Code

codex_lane.py now exits 2 with a clear message, before creating any lane
output, when layers are pending and codex is not on PATH; a new host
previously got a FileNotFoundError traceback per attempt. The dry run is
unaffected. The new codex_lane.py hash is appended to lane-provenance.json.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
@seathatflowsinourveins
seathatflowsinourveins enabled auto-merge (squash) September 23, 2026 18:09
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-23T18:11:37.533119Z 148178a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@seathatflowsinourveins
seathatflowsinourveins merged commit 769f1b1 into main Sep 23, 2026
17 checks passed
@seathatflowsinourveins
seathatflowsinourveins deleted the claude/codex-lane-which-20260923 branch September 23, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant