Skip to content

Practice rows: --max-findings, marketplace autoUpdate and trust, the workflow model override, the effortLevel origin - #1147

Open
seathatflowsinourveins wants to merge 1 commit into
mainfrom
claude/cc-native-practice-ledger-rows-2-20261015
Open

seathatflowsinourveins wants to merge 1 commit into
mainfrom
claude/cc-native-practice-ledger-rows-2-20261015

Conversation

@seathatflowsinourveins

Copy link
Copy Markdown
Collaborator

Scope

  • What this PR changes, in one or two sentences: four practice-skill row edits. Three come from the 2026-10-15 guide screen (items 15, 35 and 60); the fourth records the origin of the project's effortLevel "xhigh" (the command center's item Verify rendered dashboards and fix memory panel usability #42).
  • Base commit: f165498aa
  • Lane: lane:foundation
  • Owned paths touched:
    • .claude/skills/claude-native-practice/reference/slots.json and three rendered layer pages;
    • the slot manifest;
    • tests/test_native_practice_ledger_rows_2.py (new);
    • manifests/evidence.json.
Row Change
pr-review-pre-cue (notes) Local /code-review runs pass --max-findings explicitly, because the choice is reused until --max-findings default.
plugin-marketplaces (notes) A repository's extraKnownMarketplaces entries apply only after workspace trust; a -p run in an untrusted folder ignores them. autoUpdate defaults to true for official Anthropic marketplaces and to false for third-party ones, so set it per entry.
model-effort-routing (route) CLAUDE_CODE_WORKFLOW_SUBAGENT_MODEL joins the keep-unset list. It runs every workflow agent on one model, overriding per-agent choices.
model-effort-routing (notes) effortLevel "xhigh" in .claude/settings.json comes from #479 (squash ba31dcd02, 2026-09-29). At 2.1.284, ultracode neither raised nor overrode effort, so a session with no saved level ran at medium. Kept, and recorded without a change.

Two more items from the same screen land in other open PRs that already edit those rows:

  • item 26, the syncClaudeAiSkills wording, goes in the skills PR;
  • item 29, the autoMemoryDirectory trust rule, goes in the memory-maintenance PR.

SOTA sources

Evidence-class table

Claim Evidence class Command / receipt
The CHANGELOG and docs lines above source_review CHANGELOG at 94506ff0; settings-reference fetched 2026-10-15
The effortLevel origin source_review git log -S'"effortLevel"' -- .claude/settings.json → ba31dcd

Local commands run

$ python3 -m unittest tests.test_native_practice_ledger_rows_2      # before the change
FAILED (failures=4)
$ python3 -m unittest tests.test_native_practice_*  (9 modules)
Ran 105 tests; OK (skipped=3)
$ python3 scripts/validate.py
rc 0

Notes for the reads

Every open practice-row PR (#1142, #1146, this one, and the memory and skills PRs) rewrites the slot manifest's sha256_when_labeled. Each one after the first to land needs a manifest rebase, recomputed from the merged slots.json.

Checklist

  • No GitHub Actions changed.
  • No workflows changed.
  • No secrets are printed, logged or committed.
  • No new paid hosting, subscription or billing surface.
  • Peer-owned untracked files and worktrees were preserved.

🤖 Generated with Claude Code

…workflow model override, the effortLevel origin

From the 2026-10-15 guide screen (items 15, 35, 60) and the command
center's item #42:

- pr-review-pre-cue: local /code-review runs pass --max-findings
  explicitly, because the choice is reused until --max-findings default
  (CHANGELOG 2.1.288).
- plugin-marketplaces: extraKnownMarketplaces entries from a repository
  apply only after workspace trust (a -p run in an untrusted folder ignores
  them); autoUpdate defaults true for official Anthropic marketplaces and
  false for third-party ones, so set it per entry (settings-reference at
  2.1.300).
- model-effort-routing route: CLAUDE_CODE_WORKFLOW_SUBAGENT_MODEL
  (2.1.296: every workflow agent on one model) joins the keep-unset list.
- model-effort-routing notes: the project settings' effortLevel "xhigh"
  comes from #479 (squash ba31dcd, 2026-09-29;
  docs/decisions/2026-09-29-sonnet-5-5-dispatch.md); kept, recorded without
  a change.

tests/test_native_practice_ledger_rows_2.py: 4 of 5 tests failed before
(the fifth pins the page render); native-practice modules 105 OK;
validate rc 0.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lane:foundation Foundation lane: Claude/Codex setup, hosts, memory, RAG, research, workers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant