Repository navigation
Practice rows: --max-findings, marketplace autoUpdate and trust, the workflow model override, the effortLevel origin - #1147
Open
seathatflowsinourveins wants to merge 1 commit into
Conversation
…workflow model override, the effortLevel origin From the 2026-10-15 guide screen (items 15, 35, 60) and the command center's item #42: - pr-review-pre-cue: local /code-review runs pass --max-findings explicitly, because the choice is reused until --max-findings default (CHANGELOG 2.1.288). - plugin-marketplaces: extraKnownMarketplaces entries from a repository apply only after workspace trust (a -p run in an untrusted folder ignores them); autoUpdate defaults true for official Anthropic marketplaces and false for third-party ones, so set it per entry (settings-reference at 2.1.300). - model-effort-routing route: CLAUDE_CODE_WORKFLOW_SUBAGENT_MODEL (2.1.296: every workflow agent on one model) joins the keep-unset list. - model-effort-routing notes: the project settings' effortLevel "xhigh" comes from #479 (squash ba31dcd, 2026-09-29; docs/decisions/2026-09-29-sonnet-5-5-dispatch.md); kept, recorded without a change. tests/test_native_practice_ledger_rows_2.py: 4 of 5 tests failed before (the fifth pins the page render); native-practice modules 105 OK; validate rc 0. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This was referenced Oct 15, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
effortLevel"xhigh" (the command center's item Verify rendered dashboards and fix memory panel usability #42).f165498aalane:foundation.claude/skills/claude-native-practice/reference/slots.jsonand three rendered layer pages;tests/test_native_practice_ledger_rows_2.py(new);manifests/evidence.json.pr-review-pre-cue(notes)/code-reviewruns pass--max-findingsexplicitly, because the choice is reused until--max-findings default.plugin-marketplaces(notes)extraKnownMarketplacesentries apply only after workspace trust; a-prun in an untrusted folder ignores them.autoUpdatedefaults to true for official Anthropic marketplaces and to false for third-party ones, so set it per entry.model-effort-routing(route)CLAUDE_CODE_WORKFLOW_SUBAGENT_MODELjoins the keep-unset list. It runs every workflow agent on one model, overriding per-agent choices.model-effort-routing(notes)effortLevel"xhigh" in.claude/settings.jsoncomes from #479 (squashba31dcd02, 2026-09-29). At 2.1.284, ultracode neither raised nor overrode effort, so a session with no saved level ran at medium. Kept, and recorded without a change.Two more items from the same screen land in other open PRs that already edit those rows:
syncClaudeAiSkillswording, goes in the skills PR;autoMemoryDirectorytrust rule, goes in the memory-maintenance PR.SOTA sources
94506ff0d3bd9185f1752da36e968775021fb48f:--max-findings <n>|allto /code-review … the choice is reused until you pass--max-findings default";CLAUDE_CODE_WORKFLOW_SUBAGENT_MODELto run every workflow agent on one model while other subagents keep theirs".extraKnownMarketplaces(fetched 2026-10-15, client 2.1.300):-prun there, it ignores them";claude-plugins-officialand most other official Anthropic marketplaces default totrue, and third-party marketplaces default tofalse."ba31dcd02102b968c696424b9f3966bf0b9334a5, with recorddocs/decisions/2026-09-29-sonnet-5-5-dispatch.md.Evidence-class table
source_reviewsource_reviewgit log -S'"effortLevel"' -- .claude/settings.json→ ba31dcdLocal commands run
Notes for the reads
Every open practice-row PR (#1142, #1146, this one, and the memory and skills PRs) rewrites the slot manifest's
sha256_when_labeled. Each one after the first to land needs a manifest rebase, recomputed from the mergedslots.json.Checklist
🤖 Generated with Claude Code